Pickup Tower Project's repo-sync status

[jameswnl]

To allow user to know if Tower's latest attempt to sync a repo's playbooks is successful or not.

Part of the pivotal tracker story

Note: the other property we can use (instead of last_update_failed) is the status ([successful|failed|missing|...]). Obviously, we can have both of them (plus some other fields) captured. They all give us different aspects of the repo state. But I think we probably want to be as frugal as possible. And status needs string comparison, vs the last_update_failed boolean check, I pick boolean.

But 1 point to consider status is that In Tower, there's a manual type repo, there wouldn't be a sync and so last_update_failed won't be meaningful. The project.status would show if there's problem with it.

However, we only support Git type now. so I need someone to push one way or the other. ( @Fryguy @blomquisg )

@miq-bot add_labels enhancement, providers/ansible_tower, fine/yes

==== Updates ====
Switched to pickup status instead of last_update_failed

==== Related bug ====
https://bugzilla.redhat.com/show_bug.cgi?id=1439357

[durandom]

besides rubocop alignment 👍

[carbonin]

This is going to be confusing. Brace yourselves.

When we branched fine we changed the spec that insures migrations will always be run in order. This makes backporting migrations to fine ... difficult.

Since fine was branched more migrations have been added to master, specifically these:

20170324124452_add_vendor_property_to_physical_server.rb
20170328110106_fix_expression_in_tenant_quota_report.rb
20170404213245_add_loc_led_state_to_physical_servers.rb

These migrations were not backported to fine.
The last migration in the fine branch is 20170320195659_remove_oid_integer_args_from_miq_queue.rb

This means that for us to backport this safely, your migration needs to be numbered between 20170320195659 and 20170324124452 - preferably an earlier number, in case we need to do this again. I'll go ahead and suggest 20170320195660

[jameswnl]

@carbonin thanks, I've renamed the file to that timestamp you suggested.

@durandom I've updated the code, to pick up status instead of last_update_failed, status would be more informative.

[miq-bot]

Checked commits jameswnl/manageiq@46ae44b~...dd66fdd with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
4 files checked, 0 offenses detected
Everything looks good. 🍪

[carbonin]

Thanks @jameswnl

[jameswnl]

@miq-bot add_label bug

[jameswnl]

@Fryguy can you merge this? Greg B is on PTO this week.

Or @bdunne

[simaishi]

Fine backport details:

$ git log -1
commit 8479214d9e5f57b60c136763fb9414a91e7e7f10
Author: Jason Frey <fryguy9@gmail.com>
Date:   Tue Apr 11 10:58:10 2017 -0400

    Merge pull request #14687 from jameswnl/repo-status
    
    Pickup Tower Project's repo-sync status
    (cherry picked from commit 84006ef20e6b0b17b286478769594e7b656bf4d3)