Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define new product features for specific types of Storage Managers #14745

Merged

Conversation

jzigmund
Copy link

Need these features to handle role_allows for already defined toolbar buttons

This PR together with ManageIQ/manageiq-ui-classic#1020 is bugfix for https://bugzilla.redhat.com/show_bug.cgi?id=1440108

@miq-bot
Copy link
Member

miq-bot commented Apr 12, 2017

Checked commit jzigmund@0d38639 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks good. 🏆

@dclarizio
Copy link

@gtanzillo could you merge this, we have a UI PR that is blocked and we want to try to get that into this release. Thx, Dan

Copy link
Member

@gtanzillo gtanzillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@gtanzillo gtanzillo added this to the Sprint 59 Ending Apr 24, 2017 milestone Apr 20, 2017
@gtanzillo gtanzillo merged commit a8afcb8 into ManageIQ:master Apr 20, 2017
simaishi pushed a commit that referenced this pull request Apr 20, 2017
…anagers

Define new product features for specific types of Storage Managers
(cherry picked from commit a8afcb8)
@simaishi
Copy link
Contributor

Fine backport details:

$ git log -1
commit ba62829409da5ff3aca7c959bde521c94c24714c
Author: Gregg Tanzillo <gtanzill@redhat.com>
Date:   Thu Apr 20 11:40:00 2017 +0200

    Merge pull request #14745 from jzigmund/define_features_for_storage_managers
    
    Define new product features for specific types of Storage Managers
    (cherry picked from commit a8afcb8e7a08236dabb75bdeaae12ad9a3159090)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants