Added jobs.target_class and jobs.target_id to returned dataset in MiqTask.yaml view #14932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Reason for adding: those attributes used for drilldowns from job to target VM. Removed job.guid column from dataset. Reason for removing: before merging Jobs and Tasks screens, jobs.guid was used to filter out tasks which have linked Jobs, after merging that filtering logic was removed
|
@yrudman Cannot apply the following label because they are not recognized: tasks |
|
Checked commit yrudman@add392f with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@chessbyte change makes sense to me 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After merging
JobsandMiqTaskmanagement screens in ManageIQ/manageiq-ui-classic#242 we lost some functionality: navigation to target object of SmartState Analysis for selected job. To fix it, we need to havejobs.target_classandjobs.target_idin dataset returned by corresponding view (MiqTask.yaml)In this PR:
jobs.target_classandjobs.target_idto include section inMiqTask.yamljobs.guidfrom to include section inMiqTask.yaml.Reason for removing: before merging
JobandMiqTaskscreens,jobs.guidwas used to filter out tasks which have linked Jobs, after merging that filtering logic was removed.There are no any changes in UI.
AFTER:
@miq-bot add-label fine/no, tasks, bug