Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Memory chart for Availability Zones #14938

Conversation

@PanSpagetka
Copy link
Contributor

PanSpagetka commented Apr 28, 2017

Add Memory chart for Availability Zones. I deleted this chart in #12609 but now i figure out hat it was wrong fix. For some providers, which don't support memory CU collection, chart will all values equal zero.

Screenshots

Before:
screencapture-localhost-3000-availability_zone-show-10000000000006-1493711457392

After:
screencapture-localhost-3000-availability_zone-show-10000000000006-1493711545432

Links [Optional]

#12609

Steps for Testing/QA [Optional]

@miq-bot miq-bot added the wip label Apr 28, 2017
@PanSpagetka PanSpagetka force-pushed the PanSpagetka:add-memory-chart-for-availiability-zones branch to 8ee1fd1 May 2, 2017
@miq-bot

This comment has been minimized.

Copy link
Member

miq-bot commented May 2, 2017

Checked commit PanSpagetka@8ee1fd1 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks fine. ⭐️

@PanSpagetka PanSpagetka changed the title [WIP] Add Memory chart for Availability Zones Add Memory chart for Availability Zones May 2, 2017
@PanSpagetka

This comment has been minimized.

Copy link
Contributor Author

PanSpagetka commented May 2, 2017

@miq-bot remove_label wip

@miq-bot miq-bot removed the wip label May 2, 2017
@isimluk
isimluk approved these changes May 2, 2017
Copy link
Contributor

isimluk left a comment

👍

@isimluk

This comment has been minimized.

Copy link
Contributor

isimluk commented May 2, 2017

It seems that we now need more proper fix for https://bugzilla.redhat.com/show_bug.cgi?id=1393574

@isimluk isimluk self-assigned this May 2, 2017
@isimluk isimluk added this to the Sprint 60 Ending May 8, 2017 milestone May 2, 2017
@isimluk

This comment has been minimized.

Copy link
Contributor

isimluk commented May 2, 2017

@PanSpagetka please attach bz for proper euwe & fine backport.

@isimluk isimluk merged commit e096670 into ManageIQ:master May 2, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 43.039%
Details
simaishi added a commit that referenced this pull request May 12, 2017
…iability-zones

Add Memory chart for Availability Zones
(cherry picked from commit e096670)
@simaishi

This comment has been minimized.

Copy link
Contributor

simaishi commented May 12, 2017

Euwe backport details:

$ git log -1
commit 0e433d922e59825736b7509ca0ba95f1ad3b0b2a
Author: Šimon Lukašík <isimluk@fedoraproject.org>
Date:   Tue May 2 12:56:13 2017 +0200

    Merge pull request #14938 from PanSpagetka/add-memory-chart-for-availiability-zones
    
    Add Memory chart for Availability Zones
    (cherry picked from commit e096670f7077e1203fdbefde2322b6e08acd6fa8)
@simaishi simaishi added euwe/backported and removed euwe/yes labels May 12, 2017
@simaishi

This comment has been minimized.

Copy link
Contributor

simaishi commented May 12, 2017

simaishi added a commit that referenced this pull request Jun 2, 2017
…iability-zones

Add Memory chart for Availability Zones
(cherry picked from commit e096670)
@simaishi

This comment has been minimized.

Copy link
Contributor

simaishi commented Jun 2, 2017

Fine backport details:

$ git log -1
commit 5a83bb8f3847384449284babc2635f7e5938d8a5
Author: Šimon Lukašík <isimluk@fedoraproject.org>
Date:   Tue May 2 12:56:13 2017 +0200

    Merge pull request #14938 from PanSpagetka/add-memory-chart-for-availiability-zones
    
    Add Memory chart for Availability Zones
    (cherry picked from commit e096670f7077e1203fdbefde2322b6e08acd6fa8)
@simaishi simaishi added fine/backported and removed fine/yes labels Jun 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.