New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use secure sessions in containers #15819

Merged
merged 1 commit into from Aug 16, 2017

Conversation

Projects
None yet
5 participants
@bdunne
Member

bdunne commented Aug 15, 2017

This allows us to use http inside the application and move the SSL logic to the route

Don't use secure sessions in containers
This allows us to use http inside the application and move the SSL logic
to the route

@bdunne bdunne requested a review from carbonin Aug 15, 2017

@bdunne

This comment has been minimized.

Show comment
Hide comment
@bdunne

bdunne Aug 15, 2017

Member

We discussed doing this in Settings and via ENV variable, but we need:
false if rails env == dev
true on an appliance
false on a container

Member

bdunne commented Aug 15, 2017

We discussed doing this in Settings and via ENV variable, but we need:
false if rails env == dev
true on an appliance
false on a container

@miq-bot

This comment has been minimized.

Show comment
Hide comment
@miq-bot

miq-bot Aug 15, 2017

Member

Checked commit bdunne@ef29796 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. 👍

Member

miq-bot commented Aug 15, 2017

Checked commit bdunne@ef29796 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. 👍

@carbonin carbonin assigned carbonin and unassigned gtanzillo Aug 16, 2017

@carbonin carbonin merged commit 24cbe04 into ManageIQ:master Aug 16, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 71.732%
Details

@bdunne bdunne deleted the bdunne:secure_session_store branch Aug 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment