Use custom buttons ids from relation instead of from CustomButtonSet#set_data[:button_order] #15873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lpichler Cannot apply the following label because they are not recognized: technical_debt |
chessbyte
reviewed
Aug 22, 2017
app/models/custom_button_set.rb
Outdated
| filtered_ids = custom_button_from_set.select { |x| x.evaluate_visibility_expression_for(object) }.pluck(:id) | ||
| if filtered_ids.present? | ||
| custom_button_set.set_data[:button_order] ||= {} |
There was a problem hiding this comment.
Why this line of code if this will be overwritten by the next line of code?
There was a problem hiding this comment.
yes, it is not needed, thanks, fixed
…set_date[:button_order] we cannot rely on CustomButtonSet#set_date[:button_order] as well as on CustomButtonSet#custom_buttons
lpichler
force-pushed
the
use_custom_buttons_ids_instead_of_set_data#button_order
branch
from
82d3f96
to
d4f8dda
Compare
|
Checked commits lpichler/manageiq@70ca73f~...d4f8dda with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
lpichler
deleted the
use_custom_buttons_ids_instead_of_set_data#button_order
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we cannot rely on CustomButtonSet#set_date[:button_order] as well
as on CustomButtonSet#custom_buttons
also, it was a problem for UI specs, but it was solved in this commit ManageIQ/manageiq-ui-classic@3f46a60
(it was about keeping CustomButtonSet#set_date[:button_order] same as CustomButtonSet#custom_buttons )
@miq-bot add_label technical_debt
@MIT-bot assign @gtanzillo
cc @martinpovolny
Links
method added here
#15725