Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update_spid! on timeout, not on each message #16384

Merged

Conversation

jrafanie
Copy link
Member

@jrafanie jrafanie commented Nov 2, 2017

https://bugzilla.redhat.com/show_bug.cgi?id=1508989

We were issuing many redundant queries per minute per queue worker
process because the spid will not change that often.

It was originally added a long time ago in:
commit fbf3233daefe45c97f18bb486bfdade55ab371f3
Date: Fri May 11 23:49:33 2012 +0000
BugzID:14803

We can eliminate these queries and only do it when we actually
reconnect! following a timeout.

https://bugzilla.redhat.com/show_bug.cgi?id=1508989

We were issuing many redundant queries per minute per queue worker
process because the spid will not change that often.

It was originally added a long time ago in:
commit fbf3233daefe45c97f18bb486bfdade55ab371f3
Date:   Fri May 11 23:49:33 2012 +0000
BugzID:14803

We can eliminate these queries and only do it when we actually
reconnect! following a timeout.
@jrafanie
Copy link
Member Author

jrafanie commented Nov 2, 2017

@miq-bot add_label gaprindashvili/yes
@miq-bot add_label fine/yes
@miq-bot add_label euwe/yes
@miq-bot add_label darga/yes
@miq-bot add_label performance
@miq-bot add_label core/workers

@miq-bot
Copy link
Member

miq-bot commented Nov 2, 2017

Checked commit jrafanie@e383939 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. 🍪

Copy link
Member

@gtanzillo gtanzillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gtanzillo gtanzillo added this to the Sprint 73 Ending Nov 13, 2017 milestone Nov 2, 2017
@gtanzillo gtanzillo merged commit 9c53f30 into ManageIQ:master Nov 2, 2017
@jrafanie jrafanie deleted the do_not_update_spids_when_getting_message branch November 2, 2017 18:12
simaishi pushed a commit that referenced this pull request Nov 6, 2017
…ing_message

update_spid! on timeout, not on each message
(cherry picked from commit 9c53f30)

https://bugzilla.redhat.com/show_bug.cgi?id=1509420
@simaishi
Copy link
Contributor

simaishi commented Nov 6, 2017

Euwe backport details:

$ git log -1
commit ad30373affa3751deb0b51f90a4eaddaf8eee520
Author: Gregg Tanzillo <gtanzill@redhat.com>
Date:   Thu Nov 2 13:45:07 2017 -0400

    Merge pull request #16384 from jrafanie/do_not_update_spids_when_getting_message
    
    update_spid! on timeout, not on each message
    (cherry picked from commit 9c53f307cfee52e6dbf2d887ffc290233a6be035)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1509420

simaishi pushed a commit that referenced this pull request Nov 6, 2017
…ing_message

update_spid! on timeout, not on each message
(cherry picked from commit 9c53f30)

https://bugzilla.redhat.com/show_bug.cgi?id=1509418
@simaishi
Copy link
Contributor

simaishi commented Nov 6, 2017

Gaprindashvili backport details:

$ git log -1
commit 9a05bc493c0cd721f75f0c74fec8aace5e135946
Author: Gregg Tanzillo <gtanzill@redhat.com>
Date:   Thu Nov 2 13:45:07 2017 -0400

    Merge pull request #16384 from jrafanie/do_not_update_spids_when_getting_message
    
    update_spid! on timeout, not on each message
    (cherry picked from commit 9c53f307cfee52e6dbf2d887ffc290233a6be035)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1509418

simaishi pushed a commit that referenced this pull request Nov 13, 2017
…ing_message

update_spid! on timeout, not on each message
(cherry picked from commit 9c53f30)

https://bugzilla.redhat.com/show_bug.cgi?id=1509419
@simaishi
Copy link
Contributor

Fine backport details:

$ git log -1
commit f914643cf811de48fa27f8d07a0073edac4e771c
Author: Gregg Tanzillo <gtanzill@redhat.com>
Date:   Thu Nov 2 13:45:07 2017 -0400

    Merge pull request #16384 from jrafanie/do_not_update_spids_when_getting_message
    
    update_spid! on timeout, not on each message
    (cherry picked from commit 9c53f307cfee52e6dbf2d887ffc290233a6be035)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1509419

d-m-u pushed a commit to d-m-u/manageiq that referenced this pull request Jun 6, 2018
…hen_getting_message

update_spid! on timeout, not on each message
(cherry picked from commit 9c53f30)

https://bugzilla.redhat.com/show_bug.cgi?id=1509419
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants