/manageiq

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: ESxi host does not exit maintenance mode. #16710

Merged
merged 1 commit into from Jan 5, 2018

Conversation

Reviewers
No reviews
Assignees

@chessbyte chessbyte

Labels
Projects
None yet
Milestone
  Sprint 77 Ending ...
5 participants
@Imaanpreet @miq-bot @simaishi @agrare @chessbyte
@Imaanpreet
Contributor

Imaanpreet commented Dec 21, 2017

TODO: Need to write test cases for this

https://bugzilla.redhat.com/show_bug.cgi?id=1528210
@Imaanpreet
Fixed: ESxi host does not exit maintenance mode. 
TODO: Need to write test cases for this
Loading status checks…
08a073b
@miq-bot

This comment has been minimized.

Show comment
Hide comment
@miq-bot

miq-bot Dec 21, 2017

Member

Checked commit Imaanpreet@08a073b with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🍰
Member

miq-bot commented Dec 21, 2017

Checked commit Imaanpreet@08a073b with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🍰

@chessbyte chessbyte self-assigned this Jan 5, 2018

@chessbyte chessbyte added bug gaprindashvili/yes labels Jan 5, 2018

@chessbyte chessbyte merged commit 7a37a8a into ManageIQ:master Jan 5, 2018
2 checks passed

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.006%) to 71.651%
Details

@chessbyte chessbyte added this to the Sprint 77 Ending Jan 15, 2018 milestone Jan 5, 2018

simaishi added a commit that referenced this pull request Jan 5, 2018

@chessbyte @simaishi
Merge pull request #16710 from Imaanpreet/validate_exit_maint_mode 
Fixed: ESxi host does not exit maintenance mode.
(cherry picked from commit 7a37a8a)

https://bugzilla.redhat.com/show_bug.cgi?id=1531602
Loading status checks…
6dd1afe
@simaishi

This comment has been minimized.

Show comment
Hide comment
@simaishi

simaishi Jan 5, 2018

Contributor

Gaprindashvili backport details:

$ git log -1
commit 6dd1afe07d03850592ff5b0f4e443665063f3e92
Author: Oleg Barenboim <chessbyte@gmail.com>
Date:   Fri Jan 5 09:23:15 2018 -0500

    Merge pull request #16710 from Imaanpreet/validate_exit_maint_mode
    
    Fixed: ESxi host does not exit maintenance mode.
    (cherry picked from commit 7a37a8acbfd4d0620a788bb4200c143f97033cfa)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1531602
Contributor

simaishi commented Jan 5, 2018

Gaprindashvili backport details:

$ git log -1
commit 6dd1afe07d03850592ff5b0f4e443665063f3e92
Author: Oleg Barenboim <chessbyte@gmail.com>
Date:   Fri Jan 5 09:23:15 2018 -0500

    Merge pull request #16710 from Imaanpreet/validate_exit_maint_mode
    
    Fixed: ESxi host does not exit maintenance mode.
    (cherry picked from commit 7a37a8acbfd4d0620a788bb4200c143f97033cfa)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1531602

@simaishi simaishi added gaprindashvili/backported and removed gaprindashvili/yes labels Jan 5, 2018

@simaishi

This comment has been minimized.

Show comment
Hide comment
@simaishi

simaishi Apr 12, 2018

Contributor

@agrare I assume this can be fine/yes?
Contributor

simaishi commented Apr 12, 2018

@agrare I assume this can be fine/yes?

@agrare agrare added the fine/yes label Apr 13, 2018

@agrare

This comment has been minimized.

Show comment
Hide comment
@agrare

agrare Apr 13, 2018

Member

@simaishi yes
Member

agrare commented Apr 13, 2018

@simaishi yes

simaishi added a commit that referenced this pull request Apr 16, 2018

@chessbyte @simaishi
Merge pull request #16710 from Imaanpreet/validate_exit_maint_mode 
Fixed: ESxi host does not exit maintenance mode.
(cherry picked from commit 7a37a8a)

https://bugzilla.redhat.com/show_bug.cgi?id=1568042
df48236
@simaishi

This comment has been minimized.

Show comment
Hide comment
@simaishi

simaishi Apr 16, 2018

Contributor

Fine backport details:

$ git log -1
commit df482362cd4950381cb5ed013d4defb9195f1116
Author: Oleg Barenboim <chessbyte@gmail.com>
Date:   Fri Jan 5 09:23:15 2018 -0500

    Merge pull request #16710 from Imaanpreet/validate_exit_maint_mode
    
    Fixed: ESxi host does not exit maintenance mode.
    (cherry picked from commit 7a37a8acbfd4d0620a788bb4200c143f97033cfa)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1568042
Contributor

simaishi commented Apr 16, 2018

Fine backport details:

$ git log -1
commit df482362cd4950381cb5ed013d4defb9195f1116
Author: Oleg Barenboim <chessbyte@gmail.com>
Date:   Fri Jan 5 09:23:15 2018 -0500

    Merge pull request #16710 from Imaanpreet/validate_exit_maint_mode
    
    Fixed: ESxi host does not exit maintenance mode.
    (cherry picked from commit 7a37a8acbfd4d0620a788bb4200c143f97033cfa)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1568042

@simaishi simaishi added fine/backported and removed fine/yes labels Apr 16, 2018

d-m-u added a commit to d-m-u/manageiq that referenced this pull request Jun 6, 2018

@chessbyte @d-m-u
Merge pull request ManageIQ#16710 from Imaanpreet/validate_exit_maint… 
…_mode

Fixed: ESxi host does not exit maintenance mode.
(cherry picked from commit 7a37a8a)

https://bugzilla.redhat.com/show_bug.cgi?id=1568042
055dbeb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment