New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Openstack Cinder EventCatcher worker #17351

Merged
merged 1 commit into from Apr 30, 2018

Conversation

@mansam
Contributor

mansam commented Apr 26, 2018

In order to capture volume events for targeted refresh, the Openstack Cinder manager needs its own event catcher.

Depends on: ManageIQ/manageiq-providers-openstack#281

https://bugzilla.redhat.com/show_bug.cgi?id=1570965

@mansam mansam changed the title from Add Openstack Cinder EventCatcher worker to (Depends on ManageIQ/manageiq-providers-openstack#281) Add Openstack Cinder EventCatcher worker Apr 26, 2018

@mansam mansam changed the title from (Depends on ManageIQ/manageiq-providers-openstack#281) Add Openstack Cinder EventCatcher worker to (Depends on manageiq-providers-openstack#281) Add Openstack Cinder EventCatcher worker Apr 26, 2018

@miq-bot

This comment has been minimized.

Member

miq-bot commented Apr 26, 2018

Checked commit mansam@7252fcc with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🏆

@JPrause

This comment has been minimized.

Member

JPrause commented Apr 26, 2018

@miq-bot add_label blocker

@miq-bot miq-bot added the blocker label Apr 26, 2018

@JPrause

This comment has been minimized.

Member

JPrause commented Apr 26, 2018

@mansam if this can be backported, please add label gaprindashvili/yes

@mansam

This comment has been minimized.

Contributor

mansam commented Apr 26, 2018

@miq-bot add_label gaprindashvili/yes

@JPrause

This comment has been minimized.

Member

JPrause commented Apr 27, 2018

@mansam do you know who can review and merge. We're trying to get these blocker PRs merged asap.

@mansam

This comment has been minimized.

Contributor

mansam commented Apr 27, 2018

@Ladas would you look at this one too, please? :)

@Ladas

Ladas approved these changes Apr 27, 2018

Looks great 👍

@mansam

This comment has been minimized.

Contributor

mansam commented Apr 27, 2018

manageiq-providers-openstack#281 has been merged, so this is ready to merge

@simaishi simaishi changed the title from (Depends on manageiq-providers-openstack#281) Add Openstack Cinder EventCatcher worker to Add Openstack Cinder EventCatcher worker Apr 27, 2018

@JPrause

This comment has been minimized.

Member

JPrause commented Apr 30, 2018

@aufi @mansam this seems to be the last PR to resolve the blocker issues. Who can merge this PR?

@mansam

This comment has been minimized.

Contributor

mansam commented Apr 30, 2018

Hi @agrare, would you mind taking a look?

@agrare agrare self-assigned this Apr 30, 2018

@agrare

agrare approved these changes Apr 30, 2018

@agrare agrare merged commit 03f883c into ManageIQ:master Apr 30, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.002%) to 72.628%
Details

@agrare agrare added this to the Sprint 85 Ending May 7, 2018 milestone Apr 30, 2018

simaishi added a commit that referenced this pull request Apr 30, 2018

Merge pull request #17351 from mansam/add-openstack-cinder-event-catc…
…her-workers

Add Openstack Cinder EventCatcher worker
(cherry picked from commit 03f883c)

https://bugzilla.redhat.com/show_bug.cgi?id=1573215
@simaishi

This comment has been minimized.

Contributor

simaishi commented Apr 30, 2018

Gaprindashvili backport details:

$ git log -1
commit 5bf235a76998045e2790f4400c196dfbb0c9f5ca
Author: Adam Grare <agrare@redhat.com>
Date:   Mon Apr 30 09:03:02 2018 -0400

    Merge pull request #17351 from mansam/add-openstack-cinder-event-catcher-workers
    
    Add Openstack Cinder EventCatcher worker
    (cherry picked from commit 03f883c4923cf0535d05bc6a3410411899c4c394)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1573215
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment