Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't start memcached in any container runtime #18051

Merged

Conversation

Projects
None yet
4 participants
@carbonin
Copy link
Member

carbonin commented Oct 2, 2018

This was originally fixed in 3d3f716 but was then broken again in 0735aec

This will allow the monolithic container image to run properly
cc @simaishi

Don't start memcached in any container runtime
This was originally fixed in 3d3f716 but was then broken again in 0735aec

This will allow the monolithic container image to run properly
@miq-bot

This comment has been minimized.

Copy link
Member

miq-bot commented Oct 2, 2018

Checked commit carbonin@a101c94 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🍪

@bdunne bdunne merged commit 08f42d9 into ManageIQ:master Oct 2, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@bdunne bdunne added this to the Sprint 96 Ending Oct 8, 2018 milestone Oct 2, 2018

simaishi added a commit that referenced this pull request Oct 2, 2018

Merge pull request #18051 from carbonin/dont_start_memcached_in_conta…
…iners_again

Don't start memcached in any container runtime

(cherry picked from commit 08f42d9)
@simaishi

This comment has been minimized.

Copy link
Contributor

simaishi commented Oct 2, 2018

Hammer backport details:

$ git log -1
commit fcc62dfe8ae9959d3b541735b56649a2db1699b6
Author: Brandon Dunne <brandondunne@hotmail.com>
Date:   Tue Oct 2 15:09:16 2018 -0400

    Merge pull request #18051 from carbonin/dont_start_memcached_in_containers_again
    
    Don't start memcached in any container runtime
    
    (cherry picked from commit 08f42d903fc6480acece38d6dc435567b222f8ce)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.