New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove OpenShift deployment wizard #18095

Merged
merged 1 commit into from Oct 22, 2018

Conversation

Projects
None yet
4 participants
@himdel
Contributor

himdel commented Oct 15, 2018

According to
ManageIQ/manageiq-ui-classic#2161 (comment) ,
the openshift deployment wizard is dead.

Since this was never enabled except under a product feature, removing.
Corresponding UI PR: ManageIQ/manageiq-ui-classic#4770

Introduced in #7620,
the still-relevant parts were moved to core in ManageIQ/manageiq-ui-classic#838 & #14563 (not removing those).

@himdel

This comment has been minimized.

Contributor

himdel commented Oct 15, 2018

Cc @cben

@miq-bot

This comment has been minimized.

Member

miq-bot commented Oct 15, 2018

This pull request is not mergeable. Please rebase and repush.

@miq-bot miq-bot added the unmergeable label Oct 15, 2018

Remove OpenShift deployment wizard
According to
ManageIQ/manageiq-ui-classic#2161 (comment)

the openshift deployment wizard is dead.
Since this was never enabled except under a product feature, removing.
@miq-bot

This comment has been minimized.

Member

miq-bot commented Oct 15, 2018

Checked commit himdel@ac440cb with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🏆

@cben

cben approved these changes Oct 15, 2018

✂️ 🔥 LGTM

UI removal should be merged first because it uses hide_deployment_wizard? from here

@miq-bot miq-bot removed the unmergeable label Oct 15, 2018

@himdel

This comment has been minimized.

Contributor

himdel commented Oct 16, 2018

UI PR merged :)

@bdunne bdunne closed this Oct 22, 2018

@bdunne bdunne reopened this Oct 22, 2018

@bdunne bdunne merged commit 2149c24 into ManageIQ:master Oct 22, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
coverage/coveralls Coverage increased (+0.005%) to 73.005%
Details

@bdunne bdunne added this to the Sprint 97 Ending Oct 22, 2018 milestone Oct 22, 2018

@bdunne bdunne self-assigned this Oct 22, 2018

@himdel himdel deleted the himdel:rm-wizard branch Oct 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment