Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix specs using Zone.first instead of creating a zone #18118

Merged
merged 2 commits into from Oct 22, 2018

Conversation

Projects
None yet
3 participants
@agrare
Copy link
Member

agrare commented Oct 22, 2018

A number of specs were using Zone.first or relying on
the ExtManagementSystem factory creating a new one.

@agrare

This comment has been minimized.

Copy link
Member Author

agrare commented Oct 22, 2018

@agrare agrare referenced this pull request Oct 22, 2018

Merged

Suspend providers #17452

2 of 2 tasks complete

agrare added some commits Oct 22, 2018

@agrare agrare force-pushed the agrare:fix_specs_doing_zone_first branch from 6eb18a8 to 25677ef Oct 22, 2018

@miq-bot

This comment has been minimized.

Copy link
Member

miq-bot commented Oct 22, 2018

Checked commits agrare/manageiq@8f694ce~...25677ef with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
8 files checked, 0 offenses detected
Everything looks fine. 🍰

@jrafanie jrafanie added bug test labels Oct 22, 2018

@jrafanie
Copy link
Member

jrafanie left a comment

LGTM... I'm quite sure that the factory changes will break a provider test suite but there's only way to know and fix those places.

@jrafanie jrafanie merged commit 533b292 into ManageIQ:master Oct 22, 2018

1 check passed

coverage/coveralls Coverage decreased (-0.008%) to 73.005%
Details

@agrare agrare deleted the agrare:fix_specs_doing_zone_first branch Oct 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.