Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Filters out private information from logs #18192

Closed
wants to merge 1 commit into from

Conversation

juliancheal
Copy link
Member

@juliancheal juliancheal commented Nov 13, 2018

TODO:

  • Each provider have a list of unsafe words to filter from logs
  • Method on MiQ core to collect those and pass to filter_parameters

@juliancheal juliancheal changed the title Filters out private key information [WIP] Filters out private key information Nov 13, 2018
@juliancheal juliancheal changed the title [WIP] Filters out private key information [WIP] Filters out private information from logs Nov 13, 2018
@miq-bot
Copy link
Member

miq-bot commented Nov 13, 2018

Checked commit juliancheal@6c40de2 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 2 offenses detected

config/application.rb

@miq-bot miq-bot added the wip label Nov 13, 2018
@Fryguy
Copy link
Member

Fryguy commented Dec 18, 2018

+1 for the idea of pluggable filter_parameters. I'm not sure if there's some default way that engines can modify the application config with their own config/application.rb. If not, we could always have a method on the Engine itself, and then a thing in Vmdb::Plugins that walks all the plugins looking for that method.

@miq-bot miq-bot closed this Jun 24, 2019
@miq-bot
Copy link
Member

miq-bot commented Jun 24, 2019

This pull request has been automatically closed because it has not been updated for at least 6 months.

Feel free to reopen this pull request if these changes are still valid.

Thank you for all your contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants