Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't start another refresh worker while another is stopping #18583

Merged
merged 1 commit into from Mar 25, 2019

Conversation

Projects
None yet
4 participants
@agrare
Copy link
Member

commented Mar 22, 2019

If a RefreshWorker is asked to stop (usually for exceeding memory) we
don't want to start another right away until the first has stopped.

This can lead to many refresh workers running at the same time since the
next worker that starts typically exceeds memory as well and will be
asked to shutdown also.

In addition to using a huge amount of memory
this can also lead to inventory integrity issues since it is possible
for multiple refresh workers to be running save_ems_inventory at once.

Don't start another refresh worker while another is stopping
If a RefreshWorker is asked to stop (usually for exceeding memory) we
don't want to start another right away until the first has stopped.

This can lead to many refresh workers running at the same time since the
next worker that starts typically exceeds memory as well and will be
asked to shutdown also.

In addition to using a huge amount of memory
this can also lead to inventory integrity issues since it is possible
for multiple refresh workers to be running save_ems_inventory at once.
@miq-bot

This comment has been minimized.

Copy link
Member

commented Mar 22, 2019

Checked commit agrare@1ab6883 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 👍

@agrare

This comment has been minimized.

Copy link
Member Author

commented Mar 24, 2019

@Fryguy Fryguy merged commit a1ba070 into ManageIQ:master Mar 25, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.002%) to 73.678%
Details

@Fryguy Fryguy added this to the Sprint 108 Ending Apr 1, 2019 milestone Mar 25, 2019

@agrare agrare deleted the agrare:dont_start_multiple_refresh_workers branch Mar 25, 2019

@ahrechushkin

This comment has been minimized.

Copy link

commented Apr 10, 2019

good job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.