Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Auth KeyPair Ownership feature #19124

Merged

Conversation

@PanSpagetka
Copy link
Contributor

PanSpagetka commented Aug 9, 2019

This feature is needed for adding Set Ownership screen. It should be backported to Hammer.

Links [Optional]

ManageIQ/manageiq-ui-classic#5967
ManageIQ/manageiq-ui-classic#5973
https://bugzilla.redhat.com/show_bug.cgi?id=1589766
https://bugzilla.redhat.com/show_bug.cgi?id=1730066

@PanSpagetka

This comment has been minimized.

Copy link
Contributor Author

PanSpagetka commented Aug 9, 2019

@miq-bot add_label hammer/yes

@@ -864,6 +864,10 @@
:description: Edit Tags of Key Pairs
:feature_type: control
:identifier: auth_key_pair_cloud_tag
- :name: Set Ownership
:description: Set Ownership of Instances

This comment has been minimized.

Copy link
@h-kataria

h-kataria Aug 12, 2019

Contributor

should be Set Ownership of Key Pairs

@PanSpagetka PanSpagetka force-pushed the PanSpagetka:add-keypair-ownership-feature branch from d2fe83e to b565ac8 Aug 13, 2019
@PanSpagetka PanSpagetka force-pushed the PanSpagetka:add-keypair-ownership-feature branch from b565ac8 to 1b82b59 Aug 13, 2019
@miq-bot

This comment has been minimized.

Copy link
Member

miq-bot commented Aug 13, 2019

Checked commit PanSpagetka@1b82b59 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🍰

@h-kataria h-kataria self-assigned this Aug 13, 2019
@h-kataria h-kataria merged commit 2501976 into ManageIQ:master Aug 13, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
simaishi added a commit that referenced this pull request Aug 15, 2019
@simaishi

This comment has been minimized.

Copy link
Contributor

simaishi commented Aug 15, 2019

Ivanchuk backport details:

$ git log -1
commit af239756f15f6c3a043cae70ae49790c5d2c3057
Author: Harpreet Kataria <hkataria@redhat.com>
Date:   Tue Aug 13 09:24:50 2019 -0400

    Merge pull request #19124 from PanSpagetka/add-keypair-ownership-feature
    
    Add Auth KeyPair Ownership feature
    
    (cherry picked from commit 25019761510360eebd43844de99129b430122647)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1589766
    https://bugzilla.redhat.com/show_bug.cgi?id=1730066
simaishi added a commit that referenced this pull request Aug 15, 2019
@simaishi

This comment has been minimized.

Copy link
Contributor

simaishi commented Aug 15, 2019

Hammer backport details:

$ git log -1
commit a6f851e5e8362a577741ec4474dde41cbfe76576
Author: Harpreet Kataria <hkataria@redhat.com>
Date:   Tue Aug 13 09:24:50 2019 -0400

    Merge pull request #19124 from PanSpagetka/add-keypair-ownership-feature
    
    Add Auth KeyPair Ownership feature
    
    (cherry picked from commit 25019761510360eebd43844de99129b430122647)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1741634
    https://bugzilla.redhat.com/show_bug.cgi?id=1741635
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.