Removing groups changes users current group #19376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When removing a group that is a user's current_group_id, change it.
The {before,after}_destroy hooks work differently in rails 5.2
The user-group association is now removed before the cleanup.
So using this association to lookup users will always look at
no users.
Removing this dependency focuses on users who have a stale current_group.
Which is the basic premise of this task
kbrock
force-pushed
the
rails_52_groups
branch
from
fcc4356
to
981a439
Compare
|
strange tests failure - feels like it should have been failing in the past. the update is to delete the user from the widget test - because that user is not significant in the scheme of seeing when a group is removed. |
|
Checked commit kbrock@981a439 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When removing a group that is a user's
current_group_id, change it.The
{before,after}_destroyhooks work differently in rails 5.2The user-group association is now removed before the cleanup.
So using this association to lookup users will always look at no users, since those records are deleted.
Removing this dependency then just focuses on users who have a stale current_group.
Which is the basic premise of this task
so now, user's
default_groupare properly updated.Added the third test case around groups to be super sure this is working