Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V2V] Added warm migration eligibility option to VM during its validation #19467

Merged

Conversation

@thearifismail
Copy link
Contributor

thearifismail commented Nov 6, 2019

Added warm migration eligibility option to VM during its validation. Needed by the WebUI. @mturley can provide more details if needed.

@thearifismail

This comment has been minimized.

Copy link
Contributor Author

thearifismail commented Nov 6, 2019

@miq-bot add_label transformation
@miq-bot add_reviewer @mturley

@miq-bot

This comment has been minimized.

Copy link
Member

miq-bot commented Nov 6, 2019

@thearifismail 'mturley' is an invalid reviewer, ignoring...

@mturley

This comment has been minimized.

Copy link
Contributor

mturley commented Nov 6, 2019

This meets the needs of the Migration Plan Wizard changes for warm migration, I can see compatibility on a VM level at VM discovery time:
Screenshot 2019-11-06 15 34 31

@mturley
mturley approved these changes Nov 6, 2019
@miq-bot

This comment has been minimized.

Copy link
Member

miq-bot commented Nov 6, 2019

Checked commit thearifismail@99b4df6 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 👍

@mturley

This comment has been minimized.

Copy link
Contributor

mturley commented Nov 6, 2019

@miq-bot add_reviewer @mzazrivec
@miq-bot add_reviewer @fdupont-redhat

@miq-bot miq-bot requested a review from mzazrivec Nov 6, 2019
@miq-bot

This comment has been minimized.

Copy link
Member

miq-bot commented Nov 6, 2019

@mturley 'fdupont-redhat' is an invalid reviewer, ignoring...

@thearifismail

This comment has been minimized.

Copy link
Contributor Author

thearifismail commented Nov 6, 2019

adding @agrare for merging it.
@miq-bot add_reviewer @agrare

@miq-bot miq-bot requested a review from agrare Nov 6, 2019
@martinpovolny martinpovolny merged commit 6a04684 into ManageIQ:master Nov 7, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.2%) to 73.936%
Details
@martinpovolny martinpovolny self-assigned this Nov 7, 2019
@mturley

This comment has been minimized.

Copy link
Contributor

mturley commented Nov 7, 2019

Thanks @martinpovolny !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.