Made changes to make Provisioning as required entry point. #3026
Conversation
|
@h-kataria This looks good. Can we default the provisioning/retirement entry points for a Catalog Bundle like we do for a Catalog Item? They can point to the same defaults. |
|
@gmcculloug currently default provisioning/retirement entry points are only being set for a Catalog Item for Generic or Orchestration item types. |
Display flash message when Display in Catalog is checked but Provisioning Entry Point is not selected, this change will allow save of Dialog for a resource action and prevent from adding a blank resource action. https://bugzilla.redhat.com/show_bug.cgi?id=1226428
h-kataria
force-pushed
the
catalog_item_dialog_save
branch
from
0d35143
to
4dc8d77
Compare
|
@gmcculloug please re-review/test |
|
Checked commit h-kataria@4dc8d77 with rubocop 0.27.1 vmdb/app/controllers/catalog_controller.rb
|
|
@h-kataria Test changes and it looks good. In the future I would recommend making a second commit for something like the change to add the default values. There is a clean separation between the two code changes and it makes it easy to review both pieces independently. |
Made changes to make Provisioning as required entry point.
Display flash message when Display in Catalog is checked but Provisioning Entry Point is not selected, this change will allow save of Dialog for a resource action and prevent from adding a blank resource action.
https://bugzilla.redhat.com/show_bug.cgi?id=1226428
@gmcculloug as discussed made Provisioning Entry Point as required field, please review/test.