New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed DHTMLX Layout #4825
Removed DHTMLX Layout #4825
Conversation
@epwinchell there are some padding issues with the right cell, can you help me? |
@skateman Title in Configuration is not changing, see screenshots: |
@epwinchell @skateman |
@skateman in Infrastructure: |
@romanblanco title change & PXE fixed, for the Foreman stuff we need #4808 to be merged |
@PanSpagetka PXE fixed, services VMs has some styling issue @epwinchell |
@skateman can't find another issues. |
@PanSpagetka The My Services VMs were low because of unbalanced columns - it's not related to this work. We'll deal with it separately. |
@epwinchell I've rebased & squashed your commits for the better look so you will need a pull. @romanblanco @mzazrivec @PanSpagetka please review |
<pr_mergeability_checker />This pull request is not mergeable. Please rebase and repush. |
@skateman Please remove WIP and rebase |
@miq-bot remove_label wip |
😍 Another one bites the dust cc @jrafanie Can't wait to merge this 😃 |
@Fryguy just wait for travis ;) |
@skateman Discovered a minor issue: There is an empty grey bar ( EDIT: |
@romanblanco We're aware of those and will address in a followup PR. |
@epwinchell Then, I can't find no other issues 👍 |
@Fryguy YOU can't wait to merge this? 🍕 🍺 |
Checked commits skateman/manageiq@6bc2a62~...4bbf339 with ruby 1.9.3, rubocop 0.34.2, and haml-lint 0.13.0 app/views/layouts/_x_edit_buttons.html.haml |
@Fryguy : too late 😄 |
yay! 🎉 |
#3742