Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed DHTMLX Layout #4825

Merged
merged 2 commits into from Oct 16, 2015
Merged

Removed DHTMLX Layout #4825

merged 2 commits into from Oct 16, 2015

Conversation

skateman
Copy link
Member

@skateman
Copy link
Member Author

@epwinchell there are some padding issues with the right cell, can you help me?

@romanblanco
Copy link
Member

@skateman Title in Configuration is not changing, see screenshots:

master:
screencapture-localhost-3000-ops-explorer-1444725284675
screencapture-localhost-3000-ops-explorer-1444725290800


after change:
screencapture-localhost-3000-ops-explorer-1444725323001
screencapture-localhost-3000-ops-explorer-1444725328934

@PanSpagetka
Copy link
Contributor

@epwinchell @skateman form_buttons_div is not showing up on some forms

@romanblanco
Copy link
Member

@skateman in Infrastructure:

  • PXE tab is not displayed correctly:
    screencapture-localhost-3000-pxe-explorer-1444727962566
  • Configuration Management renders shifted, and search is rendered at the bottom:
    screencapture-localhost-3000-provider_foreman-explorer-1444728622616

@skateman
Copy link
Member Author

@romanblanco title change & PXE fixed, for the Foreman stuff we need #4808 to be merged

@PanSpagetka
Copy link
Contributor

In Infrastructure - PXE - Edit PXE
firefox_screenshot_2015-10-13t11-16-38 005z
On select:
firefox_screenshot_2015-10-13t09-59-29 733z

In Services - My services, VMs are to low.
firefox_screenshot_2015-10-13t09-31-58 010z

@skateman
Copy link
Member Author

@PanSpagetka PXE fixed, services VMs has some styling issue @epwinchell

@romanblanco
Copy link
Member

@skateman can't find another issues.

@epwinchell
Copy link
Contributor

@PanSpagetka The My Services VMs were low because of unbalanced columns - it's not related to this work. We'll deal with it separately.

@skateman
Copy link
Member Author

@epwinchell I've rebased & squashed your commits for the better look so you will need a pull. @romanblanco @mzazrivec @PanSpagetka please review

@miq-bot
Copy link
Member

miq-bot commented Oct 15, 2015

<pr_mergeability_checker />This pull request is not mergeable. Please rebase and repush.

@epwinchell
Copy link
Contributor

@skateman Please remove WIP and rebase

@epwinchell
Copy link
Contributor

@miq-bot remove_label wip

@miq-bot miq-bot removed the wip label Oct 15, 2015
@Fryguy
Copy link
Member

Fryguy commented Oct 15, 2015

😍 Another one bites the dust cc @jrafanie

Can't wait to merge this 😃

@skateman skateman changed the title [WIP] Removed DHTMLX Layout Removed DHTMLX Layout Oct 15, 2015
@skateman
Copy link
Member Author

@Fryguy just wait for travis ;)

@skateman skateman changed the title Removed DHTMLX Layout [WIP] Removed DHTMLX Layout Oct 15, 2015
@romanblanco
Copy link
Member

@skateman Discovered a minor issue: There is an empty grey bar (#paginator.row) on the bottom of the page that wasn't there before your changes, see screenshot:

master:
screencapture-localhost-3000-miq_ae_class-explorer-1444946812719

after changes:
screencapture-localhost-3000-miq_ae_class-explorer-1444946852691

EDIT:
It appears to be on more pages (Simulation, Control -> Explorer, etc.)

@epwinchell
Copy link
Contributor

@romanblanco We're aware of those and will address in a followup PR.

@romanblanco
Copy link
Member

@epwinchell Then, I can't find no other issues 👍

@epwinchell
Copy link
Contributor

@Fryguy YOU can't wait to merge this? 🍕 🍺

@skateman skateman changed the title [WIP] Removed DHTMLX Layout Removed DHTMLX Layout Oct 16, 2015
@miq-bot
Copy link
Member

miq-bot commented Oct 16, 2015

Checked commits skateman/manageiq@6bc2a62~...4bbf339 with ruby 1.9.3, rubocop 0.34.2, and haml-lint 0.13.0
19 files checked, 2 offenses detected

app/views/layouts/_x_edit_buttons.html.haml

  • 🔴 Warn - Line 91, Col - - Metrics/BlockNesting: Avoid more than 3 levels of block nesting.
  • 🔴 Warn - Line 97, Col - - Line is too long. [166/160]

martinpovolny pushed a commit that referenced this pull request Oct 16, 2015
@martinpovolny martinpovolny merged commit 2dc7804 into ManageIQ:master Oct 16, 2015
@martinpovolny
Copy link

@Fryguy : too late 😄

@martinpovolny martinpovolny added this to the Sprint 31 Ending Oct 26, 2015 milestone Oct 16, 2015
@skateman skateman deleted the remove-dhx-layout branch October 16, 2015 08:01
@jrafanie
Copy link
Member

screen shot 2015-10-16 at 11 42 44 am

^ 🍰 ✂️ 🔥 🎉 😻

@Fryguy
Copy link
Member

Fryguy commented Oct 16, 2015

yay! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants