Stop using adminURL OSP service endpoints #5169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fog defaults to using adminURL OSP service endpoints for some services. A blind grep of Fog code shows the following: > identity_v2.rb: @openstack_endpoint_type = options[:openstack_endpoint_type] || 'adminURL' > identity_v3.rb: @openstack_endpoint_type = options[:openstack_endpoint_type] || 'adminURL' > image_v1.rb: @openstack_endpoint_type = options[:openstack_endpoint_type] || 'adminURL' > image_v2.rb: @openstack_endpoint_type = options[:openstack_endpoint_type] || 'adminURL' > metering.rb: @openstack_endpoint_type = options[:openstack_endpoint_type] || 'adminURL' > planning.rb: @openstack_endpoint_type = options[:openstack_endpoint_type] || 'adminURL' > volume.rb: @openstack_endpoint_type = options[:openstack_endpoint_type] || 'adminURL' By explicitly setting the openstack_endpoint_type to 'publicURL', manageIQ will always use the publicURL for all connections to any OpenStack Service Endpoint. https://bugzilla.redhat.com/show_bug.cgi?id=1276118
|
I'm a little surprised this didn't break the refresh specs ... I would have assumed that changing this setting it would have ended up using a different endpoint for at least some of the services making it different from the VCR. But, I guess if environment for the VCR used all the same IPs for all the different endpoints. We'll see what travis says, though. |
|
Checked commit blomquisg@72d6d77 with ruby 1.9.3, rubocop 0.34.2, and haml-lint 0.13.0 |
Fryguy
added a commit
that referenced
this pull request
Oct 28, 2015
…-services Stop using adminURL OSP service endpoints
Fryguy
added a commit
that referenced
this pull request
Nov 10, 2015
…-services Stop using adminURL OSP service endpoints
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fog defaults to using adminURL OSP service endpoints for some services. A blind
grep of Fog code shows the following:
By explicitly setting the openstack_endpoint_type to 'publicURL', manageIQ will
always use the publicURL for all connections to any OpenStack Service Endpoint.
https://bugzilla.redhat.com/show_bug.cgi?id=1276118