Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Added missing service models for cloud network #5438

Closed
wants to merge 24 commits into from

Conversation

mkanoor
Copy link
Contributor

@mkanoor mkanoor commented Nov 13, 2015

This is required to support automate methods that access models using
legacy provider model names which are now name-spaced.
For example: $evm.vmdb(:ems_openstack)
is now:      $evm.vmdb(:ManageIQ_Providers_Openstack_CloudManager)

https://bugzilla.redhat.com/show_bug.cgi?id=1280350
Discovered ConfigurationManager and ProvisioningManager service models were not properly converted to pluggable provider name-spacing.

https://bugzilla.redhat.com/show_bug.cgi?id=1280350
@mkanoor mkanoor changed the title Added missing service models for cloud network [WIP] Added missing service models for cloud network Nov 13, 2015
epwinchell and others added 22 commits November 13, 2015 16:06
  * create helper to calculate scrollable area height based on presence of toolbar and paging_div
Added changes to not show header/footer when in a form.
@miq-bot
Copy link
Member

miq-bot commented Nov 13, 2015

<pr_mergeability_checker />This pull request is not mergeable. Please rebase and repush.

@miq-bot
Copy link
Member

miq-bot commented Nov 13, 2015

Checked commits mkanoor/manageiq@84535e4~...5606103 with ruby 1.9.3, rubocop 0.34.2, and haml-lint 0.13.0
47 files checked, 14 offenses detected

app/controllers/application_controller/filter.rb

  • 🔶 - Line 823, Col 15 - Style/IndentHash - Use 2 spaces for indentation in a hash, relative to the first position after the preceding left parenthesis.
  • 🔶 - Line 825, Col 13 - Style/IndentHash - Indent the right brace the same as the first position after the preceding left parenthesis.

app/helpers/application_helper.rb

  • 🔴 Error - Line 1288, Col 8 - Syntax - unexpected token tSTRING_CONTENT

app/models/vm_scan.rb

app/presenters/tree_builder_vms_filter.rb

  • 🔶 - Line 5, Col 7 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.

app/views/layouts/_content.html.haml

  • 🔴 Warn - Line 99, Col - - Metrics/BlockNesting: Avoid more than 3 levels of block nesting.

lib/miq_automation_engine/engine/miq_ae_service_model_legacy.rb

lib/miq_automation_engine/service_models/miq_ae_service_manageiq-providers-openstack-cloud_manager-cloud_network-private.rb

lib/miq_automation_engine/service_models/miq_ae_service_manageiq-providers-openstack-cloud_manager-cloud_network-public.rb

lib/miq_automation_engine/service_models/miq_ae_service_manageiq-providers-openstack-infra_manager-cloud_network-private.rb

lib/miq_automation_engine/service_models/miq_ae_service_manageiq-providers-openstack-infra_manager-cloud_network-public.rb

spec/models/vm_scan_spec.rb

@chessbyte chessbyte added the wip label Nov 15, 2015
@chessbyte
Copy link
Member

Please rebase and push again

@mkanoor
Copy link
Contributor Author

mkanoor commented Nov 16, 2015

Closed in favor of #5458

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet