Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing service models for cloud network #5458

Merged
merged 3 commits into from Nov 16, 2015

Conversation

mkanoor
Copy link
Contributor

@mkanoor mkanoor commented Nov 16, 2015

gmcculloug and others added 3 commits November 16, 2015 10:59
This is required to support automate methods that access models using
legacy provider model names which are now name-spaced.
For example: $evm.vmdb(:ems_openstack)
is now:      $evm.vmdb(:ManageIQ_Providers_Openstack_CloudManager)

https://bugzilla.redhat.com/show_bug.cgi?id=1280350
Discovered ConfigurationManager and ProvisioningManager service models were not properly converted to pluggable provider name-spacing.

https://bugzilla.redhat.com/show_bug.cgi?id=1280350
@mkanoor
Copy link
Contributor Author

mkanoor commented Nov 16, 2015

@gmcculloug @matthewd
Please review

@miq-bot
Copy link
Member

miq-bot commented Nov 16, 2015

Checked commits mkanoor/manageiq@92ff2c3~...24d2d00 with ruby 1.9.3, rubocop 0.34.2, and haml-lint 0.13.0
14 files checked, 7 offenses detected

lib/miq_automation_engine/engine/miq_ae_service_model_legacy.rb

lib/miq_automation_engine/service_models/miq_ae_service_manageiq-providers-openstack-cloud_manager-cloud_network-private.rb

lib/miq_automation_engine/service_models/miq_ae_service_manageiq-providers-openstack-cloud_manager-cloud_network-public.rb

lib/miq_automation_engine/service_models/miq_ae_service_manageiq-providers-openstack-infra_manager-cloud_network-private.rb

lib/miq_automation_engine/service_models/miq_ae_service_manageiq-providers-openstack-infra_manager-cloud_network-public.rb

@gmcculloug
Copy link
Member

👍

@mkanoor
Copy link
Contributor Author

mkanoor commented Nov 16, 2015

@gmcculloug
The Travis build is green can we get this merged

@gmcculloug
Copy link
Member

@mkanoor Need to get PR #5397 merged first.

@gmcculloug gmcculloug changed the title Added missing service models for cloud network [Depends on #5397] Added missing service models for cloud network Nov 16, 2015
chessbyte added a commit that referenced this pull request Nov 16, 2015
[Depends on #5397] Added missing service models for cloud network
@chessbyte chessbyte merged commit ea6f45f into ManageIQ:master Nov 16, 2015
@chessbyte chessbyte added this to the Sprint 32 Ending Nov 16, 2015 milestone Nov 16, 2015
@gmcculloug gmcculloug changed the title [Depends on #5397] Added missing service models for cloud network Added missing service models for cloud network Nov 16, 2015
chessbyte added a commit that referenced this pull request Nov 17, 2015
[Depends on #5397] Added missing service models for cloud network
blomquisg pushed a commit to blomquisg/manageiq that referenced this pull request Nov 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants