New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate DB round trip cleanup #5649

Merged
merged 1 commit into from Dec 2, 2015

Conversation

Projects
None yet
6 participants
@mkanoor
Contributor

mkanoor commented Nov 30, 2015

https://bugzilla.redhat.com/show_bug.cgi?id=1287891

(1) Two instances were incorrectly named
(2) Many of the instances were manually edited and imported

Automate DB round trip cleanup
(1) Two instances were incorrectly named
(2) Many of the instances were manually edited and imported

@mkanoor mkanoor added the automate label Nov 30, 2015

@mkanoor

This comment has been minimized.

Show comment
Hide comment
@mkanoor
Contributor

mkanoor commented Nov 30, 2015

@tinaafitz

This comment has been minimized.

Show comment
Hide comment
@tinaafitz

tinaafitz Nov 30, 2015

Member

@mkanoor
Looks good.

Member

tinaafitz commented Nov 30, 2015

@mkanoor
Looks good.

@bzwei

This comment has been minimized.

Show comment
Hide comment
@bzwei

bzwei Dec 2, 2015

Contributor

Where are the incorrectly named instances? I could not find them.

Contributor

bzwei commented Dec 2, 2015

Where are the incorrectly named instances? I could not find them.

@mkanoor

This comment has been minimized.

Show comment
Hide comment
@mkanoor

mkanoor Dec 2, 2015

Contributor

@bzwei
the files that have been renamed are
manageiq/db/fixtures/ae_datastore/ManageIQ/Cloud/Orchestration/Reconfiguration/Email.class/methods/servicereconfigurerequest_approved.yaml

manageiq/db/fixtures/ae_datastore/ManageIQ/Infrastructure/Configured_System/Provisioning/StateMachines/Provision.class/provision_via_foreman.yaml

Contributor

mkanoor commented Dec 2, 2015

@bzwei
the files that have been renamed are
manageiq/db/fixtures/ae_datastore/ManageIQ/Cloud/Orchestration/Reconfiguration/Email.class/methods/servicereconfigurerequest_approved.yaml

manageiq/db/fixtures/ae_datastore/ManageIQ/Infrastructure/Configured_System/Provisioning/StateMachines/Provision.class/provision_via_foreman.yaml

@bzwei

This comment has been minimized.

Show comment
Hide comment
@bzwei

bzwei Dec 2, 2015

Contributor

Thanks. LGTM

Contributor

bzwei commented Dec 2, 2015

Thanks. LGTM

@lfu

This comment has been minimized.

Show comment
Hide comment
@lfu

lfu Dec 2, 2015

Member

👍

Member

lfu commented Dec 2, 2015

👍

gmcculloug added a commit that referenced this pull request Dec 2, 2015

@gmcculloug gmcculloug merged commit 466d1ac into ManageIQ:master Dec 2, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.002%) to 48.251%
Details

@Fryguy Fryguy added the bug label Dec 11, 2015

gmcculloug added a commit to dclarizio/manageiq that referenced this pull request Dec 16, 2015

Merge branch 'bugzilla_1288150_5_5_z' into '5.5.z'
Automate DB round trip cleanup

(1) Two instances were incorrectly named
(2) Many of the instances were manually edited and imported

https://bugzilla.redhat.com/show_bug.cgi?id=1288150

Clean Cherry Pick from ManageIQ#5649

See merge request !577
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment