Added tests for Automate retirement generic methods. #6357
Conversation
|
@mkanoor |
billfitzgerald0120
force-pushed
the
retirement_generic
branch
from
2b05620
to
01743d3
Compare
billfitzgerald0120
force-pushed
the
retirement_generic
branch
from
01743d3
to
6e8dcb3
Compare
|
@gmcculloug |
gmcculloug
changed the title
|
@billfitzgerald0120 @tinaafitz From what I see you added a common method call to check_pre_retirement/pre_retirement that responds to the "create" message, but the state-machine calling this instance is still passing the vendor as a message which means the new method will not be invoked. The tests are calling the method instances directly and not passing a message so they appear to work. Would be help if you could better describe the changes you are trying to make here. Is the state-machine suppose to call with a vendor message now? If so, do we need the vendor-specific calls that still exist in the method instances? |
billfitzgerald0120
force-pushed
the
retirement_generic
branch
from
6e8dcb3
to
c94b136
Compare
billfitzgerald0120
changed the title
|
@gmcculloug |
|
@billfitzgerald0120 @tinaafitz The tests are failing because you are not passing the vendor |
billfitzgerald0120
force-pushed
the
retirement_generic
branch
from
c94b136
to
49aa23e
Compare
|
@gmcculloug |
|
Checked commit billfitzgerald0120@49aa23e with ruby 2.2.3, rubocop 0.34.2, and haml-lint 0.13.0 |
Added tests for Automate retirement generic methods.
Automate - Retirement - Infrastructure added tests for pre_retirement and check_pre_retirement methods.
https://bugzilla.redhat.com/show_bug.cgi?id=1302130