AutomationEngine mutex methods #6577

dtrieu80 · 2016-02-09T17:00:18Z

New methods introduced:
$evm.with_acquired_lock(lock_name)
$evm.acquire_lock(lock_name)
$evm.release_lock(lock_name)
$evm.has_lock?(lock_name)

Need to consider deadlock solutions (lock ordering, no-nested or one-lock at a time, etc).

chessbyte · 2016-02-09T17:10:32Z

@dtrieu80 Please rebase and push again

chessbyte · 2016-02-09T17:10:53Z

@gmcculloug @mkanoor Please review

mkanoor · 2016-02-09T17:16:17Z

lib/miq_concurrency.rb

+          ActiveRecord::Base.establish_connection(ActiveRecord::Base.configurations[Rails.env])
+        end
+        unless @connection
+          @connection = ActiveRecord::Base.connection


@dtrieu80
@connection ||= ActiveRecord::Base.connection

mkanoor · 2016-02-09T17:35:46Z

@dtrieu80
Can you please add a spec for this

Fryguy · 2016-02-09T19:35:43Z

@matthewd Can you review...particularly the PgConcurrency bit?

matthewd · 2016-02-10T00:54:24Z

lib/miq_automation_engine/engine/miq_ae_service.rb

+      while Time.now < give_up_at do
+        if MiqConcurrency::PGMutex.try_advisory_lock(lock_name)
+          begin
+            yield


return yield; it's good form for a with_... method to return its block's result

this adds support for manual api auth token invalidation, via the DELETE /api/auth action (with a valid X-Auth-Token HTTP header) the token is deleted and a 204 response is returned (if no such token exists, the token validity check kicks in and returns a 401)

Plus add stub functions for __() and N_() into tests and turn off jshint warnings for them.

Callers of collect_children expect arrays. Fixes: ``` undefined method `empty?' for #<Host:0x007f9dbdbd9dd8> /~/.gem/ruby/2.2.4/gems/activemodel-4.2.5.1/lib/active_model/attribute_methods.rb:433:in `method_missing' ./app/models/condition.rb:165:in `_subst_find' ```

…chkconfig` LinuxAdmin::Service will detect if it should call `service` or `systemctl` commands when an instance is created. This makes it more portable than unconditionally using `service` and `chkconfig`.

… url is not defined. https://bugzilla.redhat.com/show_bug.cgi?id=1275840

Also, specify the source_type as rails requests. Note, we specify VmOrTemplate here because VmOrTemplate is where this has_many is located. It seems like this has_many may belong in MiqTemplate. Fixes the following error: ``` ActiveRecord::HasManyThroughSourceAssociationNotFoundError: Could not find the source association(s) :vm in model MiqProvision. Try 'has_many :miq_provision_vms, :through => :miq_provisions_from_template, :source => <name>'. Is it one of miq_request, source, destination, miq_request_tasks, miq_request_task, or tenant? ``` This resolves the model bug reported in: https://bugzilla.redhat.com/show_bug.cgi?id=1303074 We still need to see if we can generate reports based on this now fixed has_many :through.

…o textual icons

miq-bot · 2016-02-15T15:36:54Z

<pr_mergeability_checker />This pull request is not mergeable. Please rebase and repush.

miq-bot · 2016-02-15T15:41:53Z

<github_pr_commenter_batch />Some comments on commits https://github.com/dtrieu80/manageiq/compare/e2ed2f4fec3f122095b65b10c934746fd1dcaf1d~...5654aedaa530ba5b8f648aea663233be9273e2b2

Gemfile changes detected. /cc @JPrause @simaishi

miq-bot · 2016-02-15T15:44:28Z

Checked commits https://github.com/dtrieu80/manageiq/compare/e2ed2f4fec3f122095b65b10c934746fd1dcaf1d~...5654aedaa530ba5b8f648aea663233be9273e2b2 with ruby 2.2.3, rubocop 0.34.2, and haml-lint 0.13.0
396 files checked, 203 offenses detected

Gemfile

🔶 - Line 10, Col 50 - Style/ExtraSpacing - Unnecessary spacing detected.
🔶 - Line 107, Col 19 - Style/ExtraSpacing - Unnecessary spacing detected.

app/controllers/application_controller.rb

🔴 Warn - Line 954, Col 24 - Lint/AssignmentInCondition - Assignment in condition - you probably meant to use ==.
🔹 - Line 14, Col 121 - Metrics/LineLength - Line is too long. [165/120]

app/controllers/application_controller/ci_processing.rb

🔹 - Line 1675, Col 121 - Metrics/LineLength - Line is too long. [129/120]
🔹 - Line 1677, Col 121 - Metrics/LineLength - Line is too long. [133/120]

app/controllers/application_controller/compare.rb

🔹 - Line 1795, Col 3 - Metrics/AbcSize - Assignment Branch Condition size for comp_record_data_nonexistsmode is too high. [18.55/15]
🔹 - Line 1795, Col 3 - Metrics/PerceivedComplexity - Perceived complexity for comp_record_data_nonexistsmode is too high. [9/7]

app/controllers/application_controller/filter.rb

🔹 - Line 1094, Col 121 - Metrics/LineLength - Line is too long. [137/120]
🔹 - Line 1095, Col 121 - Metrics/LineLength - Line is too long. [137/120]

app/controllers/auth_key_pair_cloud_controller.rb

🔶 - Line 90, Col 7 - Style/AccessorMethodName - Do not prefix reader method names with get_.
🔹 - Line 35, Col 3 - Metrics/AbcSize - Assignment Branch Condition size for show is too high. [55.01/15]
🔹 - Line 35, Col 3 - Metrics/CyclomaticComplexity - Cyclomatic complexity for show is too high. [14/6]
🔹 - Line 35, Col 3 - Metrics/MethodLength - Method has too many lines. [41/25]
🔹 - Line 35, Col 3 - Metrics/PerceivedComplexity - Perceived complexity for show is too high. [13/7]

app/controllers/ems_common.rb

🔹 - Line 101, Col 3 - Metrics/AbcSize - Assignment Branch Condition size for view_setup_helper is too high. [26.02/15]

app/controllers/miq_policy_controller/rsop.rb

🔹 - Line 33, Col 121 - Metrics/LineLength - Line is too long. [128/120]

app/controllers/miq_request_controller.rb

🔹 - Line 202, Col 121 - Metrics/LineLength - Line is too long. [186/120]

app/controllers/provider_foreman_controller.rb

🔹 - Line 493, Col 121 - Metrics/LineLength - Line is too long. [127/120]

app/controllers/report_controller.rb

🔶 - Line 269, Col 7 - Style/AccessorMethodName - Do not prefix writer method names with set_.
🔹 - Line 277, Col 3 - Metrics/MethodLength - Method has too many lines. [27/25]

app/controllers/report_controller/reports/editor.rb

🔹 - Line 451, Col 33 - Metrics/BlockNesting - Avoid more than 3 levels of block nesting.
🔹 - Line 451, Col 121 - Metrics/LineLength - Line is too long. [180/120]

app/controllers/vm_common.rb

🔹 - Line 1666, Col 3 - Metrics/AbcSize - Assignment Branch Condition size for action_type is too high. [34.71/15]
🔹 - Line 1666, Col 3 - Metrics/CyclomaticComplexity - Cyclomatic complexity for action_type is too high. [24/6]
🔹 - Line 1666, Col 3 - Metrics/MethodLength - Method has too many lines. [48/25]

app/helpers/application_helper.rb

🔴 Warn - Line 781, Col 14 - Lint/AssignmentInCondition - Assignment in condition - you probably meant to use ==.
🔹 - Line 772, Col 3 - Metrics/AbcSize - Assignment Branch Condition size for calculate_toolbars is too high. [15.94/15]
🔹 - Line 1122, Col 121 - Metrics/LineLength - Line is too long. [133/120]

app/helpers/persistent_volume_helper/textual_summary.rb

🔶 - Line 1, Col 1 - Metrics/ModuleLength - Module has too many lines. [135/100]

app/models/cloud_volume/operations.rb

🔹 - Line 49, Col 121 - Metrics/LineLength - Line is too long. [122/120]

app/models/ems_cluster.rb

🔶 - Line 23, Col 1 - Style/EmptyLines - Extra blank line detected.

app/models/ems_refresh/save_inventory_configuration.rb

🔹 - Line 16, Col 121 - Metrics/LineLength - Line is too long. [123/120]
🔹 - Line 40, Col 121 - Metrics/LineLength - Line is too long. [135/120]

app/models/host.rb

🔶 - Line 41, Col 3 - Rails/Validation - Prefer the new style validations validates :column, inclusion: value over validates_inclusion_of.
🔹 - Line 55, Col 121 - Metrics/LineLength - Line is too long. [123/120]

app/models/import_file_upload.rb

🔹 - Line 25, Col 3 - Metrics/AbcSize - Assignment Branch Condition size for widget_list is too high. [15.33/15]

app/models/manageiq/providers/ansible_tower/configuration_manager/refresh_parser.rb

🔶 - Line 36, Col 11 - Style/AccessorMethodName - Do not prefix reader method names with get_.

app/models/manageiq/providers/azure/cloud_manager/provision/cloning.rb

🔶 - Line 1, Col 1 - Metrics/ModuleLength - Module has too many lines. [123/100]
🔶 - Line 70, Col 24 - Style/ExtraSpacing - Unnecessary spacing detected.
🔶 - Line 109, Col 28 - Style/ExtraSpacing - Unnecessary spacing detected.
🔹 - Line 17, Col 3 - Metrics/AbcSize - Assignment Branch Condition size for gather_storage_account_properties is too high. [35.5/15]
🔹 - Line 43, Col 3 - Metrics/AbcSize - Assignment Branch Condition size for prepare_for_clone_task is too high. [21.86/15]
🔹 - Line 43, Col 3 - Metrics/MethodLength - Method has too many lines. [32/25]
🔹 - Line 97, Col 3 - Metrics/AbcSize - Assignment Branch Condition size for create_nic is too high. [21.38/15]

app/models/manageiq/providers/azure/cloud_manager/refresh_parser.rb

🔶 - Line 144, Col 11 - Style/AccessorMethodName - Do not prefix reader method names with get_.
🔹 - Line 302, Col 7 - Metrics/AbcSize - Assignment Branch Condition size for parse_firewall_rules is too high. [21/15]

app/models/manageiq/providers/google/cloud_manager/provision/cloning.rb

🔹 - Line 32, Col 3 - Metrics/AbcSize - Assignment Branch Condition size for log_clone_options is too high. [21/15]

app/models/manageiq/providers/openstack/cloud_manager/provision_workflow.rb

🔶 - Line 9, Col 37 - Style/SpaceAroundOperators - Operator <= should be surrounded with a single space.

app/models/manageiq/providers/openstack/cloud_manager/refresh_parser.rb

🔶 - Line 358, Col 7 - Style/RedundantReturn - Redundant return detected.
🔶 - Line 365, Col 7 - Style/RedundantReturn - Redundant return detected.

app/models/manageiq/providers/openstack/cloud_manager/vm/operations/relocation.rb

🔶 - Line 4, Col 51 - Style/SpaceAroundOperators - Operator || should be surrounded with a single space.
🔶 - Line 20, Col 25 - Style/ExtraSpacing - Unnecessary spacing detected.

app/models/miq_action.rb

🔹 - Line 879, Col 121 - Metrics/LineLength - Line is too long. [139/120]

app/models/orchestration_template.rb

🔹 - Line 121, Col 3 - Metrics/AbcSize - Assignment Branch Condition size for save_as_orderable! is too high. [16.28/15]
🔹 - Line 121, Col 3 - Metrics/CyclomaticComplexity - Cyclomatic complexity for save_as_orderable! is too high. [7/6]

app/models/rbac.rb

🔶 - Line 270, Col 22 - Style/MultilineOperationIndentation - Align the operands of an expression in an assignment spanning multiple lines.

app/models/service.rb

🔹 - Line 215, Col 121 - Metrics/LineLength - Line is too long. [126/120]

app/models/storage.rb

🔶 - Line 7, Col 19 - Style/ExtraSpacing - Unnecessary spacing detected.

app/models/vm_or_template.rb

🔹 - Line 69, Col 121 - Metrics/LineLength - Line is too long. [146/120]
🔹 - Line 1923, Col 121 - Metrics/LineLength - Line is too long. [126/120]

app/presenters/menu/default_menu.rb

🔹 - Line 33, Col 121 - Metrics/LineLength - Line is too long. [185/120]
🔹 - Line 34, Col 121 - Metrics/LineLength - Line is too long. [184/120]

app/services/container_dashboard_service.rb

🔹 - Line 147, Col 121 - Metrics/LineLength - Line is too long. [122/120]

app/services/container_topology_service.rb

🔹 - Line 118, Col 3 - Metrics/AbcSize - Assignment Branch Condition size for entity_status is too high. [31.4/15]
🔹 - Line 118, Col 3 - Metrics/CyclomaticComplexity - Cyclomatic complexity for entity_status is too high. [12/6]
🔹 - Line 118, Col 3 - Metrics/PerceivedComplexity - Perceived complexity for entity_status is too high. [14/7]

app/views/configuration/_ui_2.html.haml

🔴 Warn - Line 42, Col - - Line is too long. [338/160]

app/views/layouts/_content.html.haml

🔴 Warn - Line 75, Col - - Metrics/BlockNesting: Avoid more than 3 levels of block nesting.

app/views/shared/views/_prov_dialog.html.haml

🔴 Warn - Line 134, Col - - Line is too long. [177/160]

config/initializers/rack_ruby_prof.rb

🔶 - Line 3, Col 3 - Rails/Output - Do not write to stdout. Use Rails' logger if you want to log.
🔶 - Line 4, Col 3 - Rails/Output - Do not write to stdout. Use Rails' logger if you want to log.
🔶 - Line 9, Col 5 - Rails/Output - Do not write to stdout. Use Rails' logger if you want to log.

config/initializers/sprockets-es6.rb

🔶 - Line 1, Col 1 - Style/FileName - Use snake_case for source file names.

config/routes.rb

🔶 - Line 131, Col 25 - Style/ExtraSpacing - Unnecessary spacing detected.
🔶 - Line 132, Col 11 - Style/ExtraSpacing - Unnecessary spacing detected.
🔶 - Line 646, Col 23 - Style/ExtraSpacing - Unnecessary spacing detected.
🔶 - Line 647, Col 11 - Style/ExtraSpacing - Unnecessary spacing detected.

db/fixtures/ae_datastore/ManageIQ/Infrastructure/VM/Provisioning/StateMachines/VMProvision_Template.class/methods/update_provision_status.rb

🔶 - Line 7, Col 12 - Style/TrailingWhitespace - Trailing whitespace detected.

db/migrate/20150914202922_correct_user_created_role_feature_sets.rb

🔹 - Line 4, Col 121 - Metrics/LineLength - Line is too long. [156/120]

gems/pending/Gemfile

🔶 - Line 88, Col 58 - Style/ExtraSpacing - Unnecessary spacing detected.

gems/pending/OpenStackExtract/MiqOpenStackVm/MiqOpenStackCommon.rb

🔶 - Line 1, Col 1 - Style/FileName - Use snake_case for source file names.
🔹 - Line 14, Col 3 - Metrics/AbcSize - Assignment Branch Condition size for get_image_file_glance_v2 is too high. [36.62/15]
🔹 - Line 14, Col 3 - Metrics/MethodLength - Method has too many lines. [26/25]
🔹 - Line 54, Col 3 - Metrics/AbcSize - Assignment Branch Condition size for get_image_file_glance_v1 is too high. [42.74/15]
🔹 - Line 54, Col 3 - Metrics/MethodLength - Method has too many lines. [33/25]

gems/pending/OpenStackExtract/MiqOpenStackVm/MiqOpenStackImage.rb

🔶 - Line 41, Col 7 - Style/VariableName - Use snake_case for variable names.

gems/pending/OpenStackExtract/MiqOpenStackVm/MiqOpenStackInstance.rb

🔶 - Line 135, Col 7 - Style/VariableName - Use snake_case for variable names.

gems/pending/VMwareWebService/MiqVimInventory.rb

🔶 - Line 251, Col 5 - Style/VariableName - Use snake_case for variable names.

gems/pending/VMwareWebService/VimPropMaps.rb

🔶 - Line 65, Col 16 - Style/ExtraSpacing - Unnecessary spacing detected.
🔶 - Line 67, Col 20 - Style/WordArray - Use %w or %W for array of words.
🔶 - Line 68, Col 20 - Style/WordArray - Use %w or %W for array of words.
🔶 - Line 327, Col 16 - Style/ExtraSpacing - Unnecessary spacing detected.
🔶 - Line 329, Col 20 - Style/WordArray - Use %w or %W for array of words.

gems/pending/VMwareWebService/wsdl41/vimws25MappingRegistry.rb

gems/pending/VolumeManager/MiqLvm.rb

🔶 - Line 317, Col 5 - Style/VariableName - Use snake_case for variable names.
🔶 - Line 318, Col 5 - Style/VariableName - Use snake_case for variable names.
🔶 - Line 322, Col 7 - Style/Next - Use next to skip iteration.
🔶 - Line 324, Col 56 - Style/SymbolProc - Pass &:metadata as an argument to collect instead of a block.
🔶 - Line 325, Col 56 - Style/SymbolProc - Pass &:pool as an argument to collect instead of a block.
🔶 - Line 327, Col 19 - Style/SpaceAroundOperators - Operator << should be surrounded with a single space.
🔶 - Line 327, Col 21 - Style/ExtraSpacing - Unnecessary spacing detected.

gems/pending/appliance_console/internal_database_configuration.rb

🔹 - Line 132, Col 121 - Metrics/LineLength - Line is too long. [154/120]

gems/pending/spec/util/miq_logger_processor_spec.rb

🔶 - Line 65, Col 5 - Style/WordArray - Use %w or %W for array of words.

lib/miq_automation_engine/service_models/miq_ae_service_manageiq-providers-azure-cloud_manager-provision.rb

🔹 - Line 2, Col 121 - Metrics/LineLength - Line is too long. [123/120]

lib/miq_automation_engine/service_models/miq_ae_service_manageiq-providers-google-cloud_manager-provision.rb

🔹 - Line 2, Col 121 - Metrics/LineLength - Line is too long. [124/120]

lib/miq_concurrency.rb

🔶 - Line 44, Col 1 - Style/EmptyLinesAroundClassBody - Extra empty line detected at class body end.

lib/token_manager.rb

🔹 - Line 26, Col 121 - Metrics/LineLength - Line is too long. [128/120]

spec/automation/unit/method_validation/update_provision_status_vm_cloud_spec.rb

🔹 - Line 25, Col 121 - Metrics/LineLength - Line is too long. [254/120]
🔹 - Line 34, Col 121 - Metrics/LineLength - Line is too long. [210/120]

spec/automation/unit/method_validation/update_provision_status_vm_infra_spec.rb

🔹 - Line 26, Col 121 - Metrics/LineLength - Line is too long. [263/120]
🔹 - Line 35, Col 121 - Metrics/LineLength - Line is too long. [219/120]

spec/automation/unit/method_validation/update_provision_status_vm_template_infra_spec.rb

🔹 - Line 26, Col 121 - Metrics/LineLength - Line is too long. [269/120]
🔹 - Line 35, Col 121 - Metrics/LineLength - Line is too long. [225/120]

spec/automation/unit/method_validation/update_service_provision_status_orchestration_spec.rb

🔶 - Line 18, Col 13 - Style/ExtraSpacing - Unnecessary spacing detected.
🔹 - Line 18, Col 121 - Metrics/LineLength - Line is too long. [313/120]
🔹 - Line 27, Col 121 - Metrics/LineLength - Line is too long. [223/120]

spec/factories/availability_zone.rb

🔹 - Line 15, Col 121 - Metrics/LineLength - Line is too long. [142/120]

spec/factories/ext_management_system.rb

🔹 - Line 108, Col 121 - Metrics/LineLength - Line is too long. [154/120]

spec/factories/security_group.rb

🔹 - Line 6, Col 121 - Metrics/LineLength - Line is too long. [130/120]
🔹 - Line 7, Col 121 - Metrics/LineLength - Line is too long. [136/120]
🔹 - Line 8, Col 121 - Metrics/LineLength - Line is too long. [128/120]

spec/factories/template_google.rb

🔹 - Line 2, Col 121 - Metrics/LineLength - Line is too long. [140/120]

spec/factories/vm_or_template.rb

🔹 - Line 23, Col 121 - Metrics/LineLength - Line is too long. [128/120]
🔹 - Line 27, Col 121 - Metrics/LineLength - Line is too long. [122/120]

spec/helpers/application_helper/toolbar_builder_spec.rb

🔹 - Line 1149, Col 121 - Metrics/LineLength - Line is too long. [142/120]

spec/lib/miq_automation_engine/miq_ae_collect_spec.rb

🔹 - Line 16, Col 121 - Metrics/LineLength - Line is too long. [206/120]
🔹 - Line 35, Col 121 - Metrics/LineLength - Line is too long. [136/120]

spec/lib/miq_automation_engine/miq_ae_provision_spec.rb

🔶 - Line 5, Col 5 - Style/IndentationWidth - Use 2 (not 0) spaces for indentation.

spec/lib/miq_automation_engine/miq_ae_service_spec.rb

spec/lib/miq_automation_engine/service_methods/miq_ae_service_manageiq-providers-cloud_manager-provision_spec.rb

🔹 - Line 96, Col 121 - Metrics/LineLength - Line is too long. [124/120]
🔹 - Line 103, Col 121 - Metrics/LineLength - Line is too long. [129/120]
🔹 - Line 150, Col 121 - Metrics/LineLength - Line is too long. [121/120]
🔹 - Line 157, Col 121 - Metrics/LineLength - Line is too long. [129/120]
🔹 - Line 232, Col 121 - Metrics/LineLength - Line is too long. [130/120]
🔹 - Line 239, Col 121 - Metrics/LineLength - Line is too long. [129/120]
🔹 - Line 260, Col 121 - Metrics/LineLength - Line is too long. [128/120]
🔹 - Line 267, Col 121 - Metrics/LineLength - Line is too long. [129/120]
🔹 - Line 288, Col 121 - Metrics/LineLength - Line is too long. [121/120]

spec/lib/miq_automation_engine/service_methods/miq_ae_service_manageiq-providers-cloud_manager-vm_spec.rb

🔶 - Line 5, Col 5 - Style/WordArray - Use %w or %W for array of words.

spec/lib/miq_automation_engine/service_methods/miq_ae_service_manageiq-providers-google-cloud_manager_spec.rb

🔶 - Line 1, Col 1 - Style/FileName - Use snake_case for source file names.
🔶 - Line 3, Col 8 - Style/ClassAndModuleCamelCase - Use CamelCase for classes and modules.

spec/lib/vmdb/configuration_encoder_spec.rb

🔶 - Line 48, Col 3 - Style/IndentationWidth - Use 2 (not 0) spaces for indentation.
🔶 - Line 56, Col 1 - Style/EmptyLines - Extra blank line detected.
🔶 - Line 58, Col 3 - Style/IndentationWidth - Use 2 (not 0) spaces for indentation.
🔶 - Line 67, Col 3 - Style/IndentationWidth - Use 2 (not 0) spaces for indentation.
🔶 - Line 76, Col 3 - Style/IndentationWidth - Use 2 (not 0) spaces for indentation.
🔶 - Line 86, Col 3 - Style/IndentationWidth - Use 2 (not 0) spaces for indentation.

spec/migrations/20150604154825_rename_container_node_conditions_to_container_conditions_spec.rb

🔶 - Line 7, Col 80 - Style/SpaceInsideBlockBraces - Space missing inside }.

spec/migrations/20151204143045_set_correct_sti_type_on_openstack_cloud_volume_spec.rb

🔶 - Line 67, Col 46 - Style/FirstParameterIndentation - Indent the first parameter one step more than the start of the previous line.
🔶 - Line 70, Col 44 - Style/ClosingParenthesisIndentation - Indent ) the same as the start of the line where ( is.

miq-bot · 2016-02-15T15:44:30Z

...continued

🔶 - Line 91, Col 46 - Style/FirstParameterIndentation - Indent the first parameter one step more than the start of the previous line.
🔶 - Line 94, Col 44 - Style/ClosingParenthesisIndentation - Indent ) the same as the start of the line where ( is.

spec/models/condition_spec.rb

🔹 - Line 27, Col 121 - Metrics/LineLength - Line is too long. [147/120]

spec/models/host_spec.rb

🔶 - Line 40, Col 7 - Style/IndentHash - Use 2 spaces for indentation in a hash, relative to the first position after the preceding left parenthesis.

spec/models/manageiq/providers/amazon/aws_helper.rb

🔹 - Line 3, Col 1 - Metrics/AbcSize - Assignment Branch Condition size for with_aws_stubbed is too high. [15.07/15]

spec/models/manageiq/providers/amazon/cloud_manager_spec.rb

🔶 - Line 71, Col 11 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.

spec/models/manageiq/providers/ansible_tower/configuration_manager/refresh_parser_spec.rb

🔹 - Line 15, Col 121 - Metrics/LineLength - Line is too long. [198/120]

spec/models/manageiq/providers/azure/cloud_manager/provision_spec.rb

🔹 - Line 18, Col 121 - Metrics/LineLength - Line is too long. [121/120]

spec/models/manageiq/providers/azure/cloud_manager/refresher_spec.rb

🔹 - Line 93, Col 3 - Metrics/AbcSize - Assignment Branch Condition size for assert_specific_security_group is too high. [17.12/15]

spec/models/manageiq/providers/openshift/container_manager/refresher_spec.rb

🔹 - Line 102, Col 3 - Metrics/AbcSize - Assignment Branch Condition size for assert_specific_container_services is too high. [23.02/15]

spec/models/manageiq/providers/openstack/cloud_manager/provision_workflow_spec.rb

🔹 - Line 167, Col 121 - Metrics/LineLength - Line is too long. [125/120]
🔹 - Line 172, Col 121 - Metrics/LineLength - Line is too long. [138/120]
🔹 - Line 173, Col 121 - Metrics/LineLength - Line is too long. [140/120]

spec/models/miq_report_spec.rb

🔶 - Line 82, Col 20 - Style/WordArray - Use %w or %W for array of words.
🔹 - Line 81, Col 121 - Metrics/LineLength - Line is too long. [802/120]
🔹 - Line 82, Col 121 - Metrics/LineLength - Line is too long. [131/120]

spec/models/miq_storage_metric_spec.rb

🔶 - Line 134, Col 35 - Style/MethodCallParentheses - Do not use parentheses for method calls with no arguments.

spec/support/automation_spec_helper.rb

🔹 - Line 95, Col 3 - Metrics/AbcSize - Assignment Branch Condition size for add_call_method is too high. [16.88/15]

tools/log_processing/ems_refresh_timings.rb

🔴 Warn - Line 63, Col 23 - Lint/Eval - The use of eval is a serious security risk.
🔹 - Line 41, Col 1 - Metrics/AbcSize - Assignment Branch Condition size for filter is too high. [16.16/15]
🔹 - Line 41, Col 1 - Metrics/CyclomaticComplexity - Cyclomatic complexity for filter is too high. [7/6]
🔹 - Line 59, Col 1 - Metrics/AbcSize - Assignment Branch Condition size for parse_refresh_timings is too high. [23.43/15]

dtrieu80 · 2016-02-15T15:55:07Z

I messed up this branch somehow. I'll need to close it and reapply a new PR.

jrafanie · 2016-02-15T15:59:13Z

@dtrieu80 ping us in https://gitter.im/ManageIQ/manageiq if you need help. Thanks!

miq-bot · 2016-02-15T16:06:14Z

<pr_mergeability_checker />This pull request is not mergeable. Please rebase and repush.

chessbyte added enhancement automate labels Feb 9, 2016

mkanoor reviewed Feb 9, 2016
View reviewed changes

matthewd reviewed Feb 10, 2016
View reviewed changes

himdel and others added 14 commits February 15, 2016 07:28

Add gettext annotations to self-service ui

7d5c9c4

Plus add stub functions for __() and N_() into tests and turn off jshint warnings for them.

Remove dictionary.tenants.* from en.yml, use gettext instead

ecc5950

API - spec for DELETE /auth

288b8cd

API.js - add support for delete, put, patch; logout invalidates token

356559f

miq-api.js - add delete, put & patch for angular as well

cabdb14

expose approve/deny a provision_request in the API

06ffa1e

simplify approve/deny, a reason is actually not required

a0e75a3

set result with action_result()

cb34abc

let bult approve/deny

7f577a4

use miq_request_approval feature identifier

3de6e04

add test, and minor enhancements

52b31d3

please rubocop

cdfffeb

simpler way to add href to the response

b6e3290

jrafanie and others added 17 commits February 15, 2016 07:36

Using LinuxAdmin::Service for calls which used to call service or `…

61f6051

…chkconfig` LinuxAdmin::Service will detect if it should call `service` or `systemctl` commands when an instance is created. This makes it more portable than unconditionally using `service` and `chkconfig`.

Do not display the Product Assistance Box for non-admin if the custom…

e7e5a8b

… url is not defined. https://bugzilla.redhat.com/show_bug.cgi?id=1275840

Do not show the RedHat support link for non-admin users

5d0e5ed

Enabled auto placement of newly provisioned Azure VMs

44d2a48

Exclude VMware API wsdl files from rubocop

a5ab8a9

Skip thin volumes in smart state analysis

9375a25

Remove debug puts in the test.

bf1f5cf

Add debugging help comment once, removing duplicates

9fb1444

more autoplacement

646a352

Azure exclusions

9f5abae

Move casting of dialog field values to separate method and add tests

5851312

Update dialog field values to support 't' in boolean field

a315497

Resolve rubocop issue with Time.parse.

baa89c0

remove url helper from topology service - not needed after the move t…

8d1c03b

…o textual icons

topology - make the check for vm entity more generic

5654aed

miq-bot added the dependencies label Feb 15, 2016

dtrieu80 closed this Feb 15, 2016

dtrieu80 deleted the ae-mutex branch February 15, 2016 18:55

Fryguy mentioned this pull request Feb 15, 2016

AE Mutex #6680

Closed

dtrieu80 mentioned this pull request Mar 1, 2016

Automation Engine Mutex and spec #7047

Closed

Fryguy mentioned this pull request Jun 27, 2018

Add a common class to implement advisory lock ManageIQ/manageiq-content#348

Closed

AutomationEngine mutex methods #6577

AutomationEngine mutex methods #6577

dtrieu80 commented Feb 9, 2016

chessbyte commented Feb 9, 2016

chessbyte commented Feb 9, 2016

mkanoor Feb 9, 2016

mkanoor commented Feb 9, 2016

Fryguy commented Feb 9, 2016

matthewd Feb 10, 2016

miq-bot commented Feb 15, 2016

miq-bot commented Feb 15, 2016

miq-bot commented Feb 15, 2016

miq-bot commented Feb 15, 2016

dtrieu80 commented Feb 15, 2016

jrafanie commented Feb 15, 2016

miq-bot commented Feb 15, 2016

AutomationEngine mutex methods #6577

AutomationEngine mutex methods #6577

Conversation

dtrieu80 commented Feb 9, 2016

chessbyte commented Feb 9, 2016

chessbyte commented Feb 9, 2016

mkanoor Feb 9, 2016

Choose a reason for hiding this comment

mkanoor commented Feb 9, 2016

Fryguy commented Feb 9, 2016

matthewd Feb 10, 2016

Choose a reason for hiding this comment

miq-bot commented Feb 15, 2016

miq-bot commented Feb 15, 2016

miq-bot commented Feb 15, 2016

miq-bot commented Feb 15, 2016

dtrieu80 commented Feb 15, 2016

jrafanie commented Feb 15, 2016

miq-bot commented Feb 15, 2016