New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update doc with SME feedback #486

Merged
merged 2 commits into from Aug 22, 2017

Conversation

Projects
None yet
3 participants
@cbudz
Contributor

cbudz commented Aug 15, 2017

Hi Dayle,

Here's the updates to the operational alerts table. Once they're approved and merged, I'll backport the content to darga/euwe/fine.

-Chris

@cbudz cbudz added this to the Sprint 67 Ending Aug 21, 2017 milestone Aug 15, 2017

@cbudz cbudz added the enhancement label Aug 15, 2017

@cbudz cbudz requested a review from dayleparker Aug 15, 2017

@dayleparker

Hey Chris,
The changes look great. I noticed a few very small things to fix, but otherwise all good. Please let me know your thoughts on those items.
Cheers,
Dayle

@miq-bot

This comment has been minimized.

Show comment
Hide comment
@miq-bot

miq-bot Aug 21, 2017

Member

Checked commits cbudz/manageiq_docs@705906d~...e991de7 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks fine. 🍰

Member

miq-bot commented Aug 21, 2017

Checked commits cbudz/manageiq_docs@705906d~...e991de7 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks fine. 🍰

@miq-bot

This comment has been minimized.

Show comment
Hide comment
@miq-bot

miq-bot Aug 21, 2017

Member

Some comments on commits cbudz/manageiq_docs@705906d~...e991de7

doc-Monitoring_Alerts_and_Reporting/topics/Operational_Alerts.adoc

  • 💣 💥 🔥 🚒 - 300 - Detected cfme
Member

miq-bot commented Aug 21, 2017

Some comments on commits cbudz/manageiq_docs@705906d~...e991de7

doc-Monitoring_Alerts_and_Reporting/topics/Operational_Alerts.adoc

  • 💣 💥 🔥 🚒 - 300 - Detected cfme
@cbudz

This comment has been minimized.

Show comment
Hide comment
@cbudz

cbudz Aug 21, 2017

Contributor

Hi Dayle,

I've made changes based on your feedback. I did replace RHEV with the full product title, and changed that awkward sentence. Let me know what you think.

-Chris

Contributor

cbudz commented Aug 21, 2017

Hi Dayle,

I've made changes based on your feedback. I did replace RHEV with the full product title, and changed that awkward sentence. Let me know what you think.

-Chris

@dayleparker

This comment has been minimized.

Show comment
Hide comment
@dayleparker

dayleparker Aug 22, 2017

Contributor

Hi Chris,
Everything looks excellent -- thanks for making those edits!
Cheers,
Dayle

Contributor

dayleparker commented Aug 22, 2017

Hi Chris,
Everything looks excellent -- thanks for making those edits!
Cheers,
Dayle

@dayleparker dayleparker merged commit be7d3f2 into ManageIQ:master Aug 22, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment