Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix for Catalog Item with Tag Control element cannot be ordered #278
Before, we were using lodash's
This changes the logic so that when a single value is to be selected, we check to see if it's a number. If it's 0 (which is the "choose" value), then we still need to select something, otherwise we should be ok. If it somehow gets set to null, we should still also be failing validation.
@miq-bot add_label gaprindashvili/yes, bug
I think this all looks solid. I would change things just a little to be a little clearer by removing the empty check from forceSingleValue and just making it an if statement below
(The PR looks good as is, but I'm wondering if #204 is not introducing more than just this bug because of it.)
@himdel Good point, I think the other scenario where it could fail then is when the field is required and the
Apr 16, 2018
Released in 1.1.11.
Backported to gaprindashvili:
Released in 1.0.22.