Add a getDeviceByLabel method #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a method to return a VirtualDevice by label and refactor the existing getDeviceKeysByLabel to use it. https://bugzilla.redhat.com/show_bug.cgi?id=1533728
|
Checked commit agrare@0a71f13 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 lib/VMwareWebService/MiqVimVm.rb
|
|
/cc @Fryguy |
roliveri
reviewed
May 8, 2018
|
|
||
| def getDeviceKeysByLabel(device_label, hardware = nil) | ||
| dev = getDeviceByLabel(device_label, hardware) | ||
| dev.values_at("controllerKey", "key", "unitNumber") unless dev.nil? |
There was a problem hiding this comment.
@agrare
Is it ok that this no longer returns an array when no devices are found?
There was a problem hiding this comment.
Yes, the only caller of this is https://github.com/ManageIQ/manageiq-providers-vmware/blob/master/app/models/manageiq/providers/vmware/infra_manager/vm/reconfigure.rb#L338 which with this changeset applied results in:
>> controller_key, key, unit_number = miq_vim_vm.send(:getDeviceKeysByLabel, "abcd")
=> nil
>> controller_key
=> nil
>> key
=> nil
>> unit_number
=> nil
|
@roliveri WDYT? |
roliveri
approved these changes
May 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a method to return a VirtualDevice by label and refactor the
existing getDeviceKeysByLabel to use it.
https://bugzilla.redhat.com/show_bug.cgi?id=1533728