Bug fixes #75
Merged
Bug fixes #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a test to check the existence of the file without appending extension to the filename, so now OGXmlConfig and its descendant classes will load files even if the extension is already given in the filename
OGBall::FindTarget() sets pTargetBall_ to 0, when no target can be found, which is dereferenced in OGBall::IsCanClimb() and OGBall::Move().
It was possible to open the pipe by catching a falling ball inside the sensor, then attaching it anywhere, because in OGContactListener::BeginContact() and OGContactListener::EndContact() the same method was called and OGSensor::BeginContact() runs after attaching the ball. The new member in OGUserData won't let sensors balls_ decrease when doing the same (OGSensor::EndContact() is also called after attaching) and avoids the pipe to remain open if a ball enters the sensor attached but leaves unattached. Setting the isTouching false in OGExitSensor::_EndContact() avoids the force to keep applied if the ball was pulled away from the pipe.
Climb target and origin are updated in OGBall::Move(), then balls are repositioned in OGClimb::onTargetChanged() if needed. It won't move the ball if OGClimb::initNewTarget() was called before updating, instead we can set a new origin and target, like in OGBall::Algorithm2(). In this case, OGClimb::onOriginChanged() will calculate the originCorrection, which is needed because usually when we set the new origin, the origin ball and our ball won't be in the same position. That would make our ball jump this distance, if we wouldn't add the originCorrection to the origin in OGClimb::onTargetChanged().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.