Skip to content
This repository has been archived by the owner on Nov 8, 2019. It is now read-only.

Add overload for Encode.int for int64? #49

Closed
danyx23 opened this issue Sep 4, 2018 · 1 comment
Closed

Add overload for Encode.int for int64? #49

danyx23 opened this issue Sep 4, 2018 · 1 comment

Comments

@danyx23
Copy link

danyx23 commented Sep 4, 2018 •
edited

I just realized that Encode.int has an overload for int32 only. This is a bit problematic since serializing bigger ints is perfectly valid. Do you agree that there should be an overload for int64 as well? I know that Javascript has a lower actual size, but I think the JSON serialization format does not limit the size of integers so serializing bigger values should be allowed IMHO. If you agree I could send a PR
@danyx23
Copy link
Author

danyx23 commented Sep 4, 2018

Sorry, I missed the int64!

@danyx23 danyx23 closed this as completed Sep 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@danyx23