New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marginal resource thumbnails aren't displaying until hovering over the icon #252

zdavis opened this Issue Apr 14, 2017 · 0 comments


None yet
1 participant

zdavis commented Apr 14, 2017

I'm seeing this in Chrome.

@zdavis zdavis added the bug label Apr 14, 2017

@zdavis zdavis self-assigned this Apr 14, 2017

@zdavis zdavis added this to the v0.1.4 milestone Apr 14, 2017

@zdavis zdavis added this to Current in Roadmap Apr 21, 2017

@zdavis zdavis removed this from Current in Roadmap Apr 21, 2017

@zdavis zdavis added the next release label Apr 21, 2017

@zdavis zdavis modified the milestone: v0.1.4 Apr 21, 2017

zdavis added a commit that referenced this issue Apr 25, 2017

[B] ResourceViewer does not display resources without SSR
This revision addresses a couple issues. Prior to this change, no
resource thumbnails were visible in the reader margins unless they
were present in the SSR load.

The cause for this was a bit involved. The ResourceViewer needs to
interact with the DOM to measure the height of the section body and
to position resource thumbnails in the correct spot in the margin.
Prior to this change, the Text container was passing a ref down
through its children. This was a less-than-ideal solution because in
many cases it was passing the ref down before the ref existed,
because the component had not yet mounted.

This commit passes a selector instead of a ref down to the
ResourceList. It also introduces a timer that checks the height of
the body container and repositions the resources if the height
changes. This is necessary for images embedded in text sections.
When those images load, the resources have to move to account for
the changed height of the section.

Closes #252

@zdavis zdavis closed this in 21d1166 Apr 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment