New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove excess left margin in backend entity header #254

Closed
zdavis opened this Issue Apr 14, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@zdavis
Member

zdavis commented Apr 14, 2017

screen shot 2017-04-07 at 12 12 23 pm

Keep in mind, many entities (Resources, for example) allow Markdown in the title, and render it in this header.

@zdavis zdavis added the bug label Apr 14, 2017

@zdavis zdavis added this to the v0.1.4 milestone Apr 14, 2017

@zdavis zdavis added this to Current in Roadmap Apr 21, 2017

@zdavis zdavis removed this from Current in Roadmap Apr 21, 2017

@zdavis zdavis added the next release label Apr 21, 2017

@zdavis zdavis modified the milestone: v0.1.4 Apr 21, 2017

naomiyaki added a commit that referenced this issue May 4, 2017

naomiyaki added a commit that referenced this issue May 4, 2017

@naomiyaki

This comment has been minimized.

Show comment
Hide comment
@naomiyaki

naomiyaki May 4, 2017

Member

It looks like in early days we were using a generic selector to grab the subtitles in these headers, but due to the lack of class selector it applied itself to these ingested headers with tags. Now, these headers require a "subtitle" class to use the secondary type style.

gpu preview 2017-05-04 14-51-21

Member

naomiyaki commented May 4, 2017

It looks like in early days we were using a generic selector to grab the subtitles in these headers, but due to the lack of class selector it applied itself to these ingested headers with tags. Now, these headers require a "subtitle" class to use the secondary type style.

gpu preview 2017-05-04 14-51-21

@naomiyaki naomiyaki added in progress and removed needs review labels May 5, 2017

zdavis added a commit that referenced this issue May 8, 2017

@zdavis zdavis closed this in #321 May 8, 2017

zdavis added a commit that referenced this issue May 8, 2017

@zdavis zdavis removed the in progress label Oct 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment