New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manifold utilizes Postgres JSONB field for storing text section content #258

Closed
zdavis opened this Issue Apr 14, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@zdavis
Member

zdavis commented Apr 14, 2017

It's currently a text field that's deserialized by TextSectionPartialSerializer:

  def body_json
    find = "/system/ingestion_sources/attachments"
    replace = Rails.configuration.manifold.api_url + find
    return "{}" if object.body_json.blank?
    JSON.parse object.body_json.gsub(find, replace)
  end

I think we should remove the gsub as well now that we're hosting the API and the client on the same domain. Even if they're on different domains, I think it'd be better to handle these paths during ingestion rather than during rendering.

@zdavis zdavis added the feature label Apr 14, 2017

scryptmouse added a commit that referenced this issue Apr 15, 2017

zdavis added a commit that referenced this issue Apr 18, 2017

@zdavis

This comment has been minimized.

Show comment
Hide comment
@zdavis

zdavis Apr 18, 2017

Member

Fixed by #3ded692

Member

zdavis commented Apr 18, 2017

Fixed by #3ded692

@zdavis zdavis closed this Apr 18, 2017

zdavis added a commit that referenced this issue Apr 21, 2017

@zdavis zdavis changed the title from Convert TextSection.body_json to json postgres field to Manifold utilizes Postgres JSONB field for storing text section content Jun 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment