Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to advance through annotations and filter for recency #2872

Closed
krosemichael opened this issue Oct 10, 2020 · 3 comments
Closed
Labels
Status: In Progress Issue is being actively worked on or has an open pull request associated with it. Type: Enhancement Issue represents new feature or expanded functionality.

Comments

@krosemichael
Copy link

krosemichael commented Oct 10, 2020

Feature Description

I would like to be able to move from one annotation to the next from within the annotation shelf and filter or sort annotations by time made or recency.

Why is this feature important? Who does it help?

This helps someone who would like to view all annotations, or all new annotations, without having to scroll through the text to locate each one.

User Stories

I am an instructor who would like to quickly read through all of the annotations my class has left on a text.

I am an author who would like to see what annotations have been left on my text.

Design Notes

I imagine two possibilities for advancing through annotations - "next" and "previous" buttons on each annotation, or a scroll of annotations in the annotation shelf.

Development Notes

@krosemichael krosemichael changed the title Add ability to advance through annotations Add ability to advance through annotations and filter for recency Oct 10, 2020
@zdavis
Copy link
Member

zdavis commented Oct 10, 2020

It would be helpful if you could break this into two issues. The first thing you're asking for—a previous/next link on each annotation—would be implemented in the single annotation component. You might also refine the request a little bit, as it wouldn't actually be moving from one annotation to the next because it's possible for multiple annotations to occupy the same space in the text, in which case they are stacked up in the drawer. What you're asking for, I think, is the ability to navigate to the next annotated spot in the text. It's a subtle distinction, but one that will matter should we build this.

The other request here—ordering annotations by the date they were created—strikes me as a distinct request. Sorting is something that generally can happen in a list. Could you be more specific about which list of annotations you want to to be be to sort? Perhaps you're talking about the annotations list in a reading group, or perhaps in "your notes", or perhaps in the expanded view of "your notes," which are the three places in Manifold where annotations are listed. Or perhaps you mean all three? In any case, each of these is a distinct interface, so we'd want separate issues if you want this functionality in all three views, since it would need to be implemented in slightly different ways for each, since each is a slightly different kind of annotation list.

Thanks!

@zdavis zdavis added the Type: Enhancement Issue represents new feature or expanded functionality. label Oct 10, 2020
@zdavis
Copy link
Member

zdavis commented Oct 10, 2020

Another thought on the "recency" request here — sorting by date is a simple ask. If what you really want here is the ability to see "new" annotations, then we would need to build a system that tracks what annotations users have seen. That would be a larger piece of development.

@zdavis zdavis added the Status: In Progress Issue is being actively worked on or has an open pull request associated with it. label Apr 8, 2021
@zdavis
Copy link
Member

zdavis commented Apr 16, 2021

I'm going to close this because I believe it will be addressed as part of the OER work. If, once that work is done, you feel we haven't solved this for you, please don't hesitate to reopen and update.

@zdavis zdavis closed this as completed Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: In Progress Issue is being actively worked on or has an open pull request associated with it. Type: Enhancement Issue represents new feature or expanded functionality.
Projects
None yet
2 participants