New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model filter loses scope after validating paginated results #299

Closed
zdavis opened this Issue Apr 28, 2017 · 1 comment

Comments

Projects
None yet
1 participant
@zdavis
Member

zdavis commented Apr 28, 2017

The filterable model concern contains functionality related to paginating filtered result sets. After the query is completed, the concern checks to see if the requested page exceeds the last available page. If it does, it re-runs the query to return results for the last available page.

The problem here is that in doing so, the initial scope passed to the filter method is not maintained.

@zdavis zdavis added bug master labels Apr 28, 2017

@zdavis zdavis self-assigned this Apr 28, 2017

@zdavis

This comment has been minimized.

Show comment
Hide comment
@zdavis

zdavis Apr 28, 2017

Member

This issue manifests in #286, and should be fixed in master before that PR is accepted.

Member

zdavis commented Apr 28, 2017

This issue manifests in #286, and should be fixed in master before that PR is accepted.

zdavis added a commit that referenced this issue Apr 28, 2017

@zdavis zdavis closed this Apr 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment