New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keyboard inputs to all modal dialogs #302

Closed
zdavis opened this Issue Apr 28, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@zdavis
Member

zdavis commented Apr 28, 2017

When there's a modal dialog UI with an OK and cancel button, users should be able to interact via keyboard input. Return should trigger the OK callback, and escape should trigger the cancel callback.

@zdavis zdavis added the bug label Apr 28, 2017

@zdavis zdavis added this to the v0.2 milestone Apr 28, 2017

@zdavis

This comment has been minimized.

Show comment
Hide comment
@zdavis

zdavis Apr 28, 2017

Member

I think this is a simple change in Dialog.Confirm...

Member

zdavis commented Apr 28, 2017

I think this is a simple change in Dialog.Confirm...

@zdavis zdavis removed this from the v0.2 milestone Apr 28, 2017

@zdavis zdavis added the master label Apr 28, 2017

@zdavis zdavis added feature and removed bug master labels May 8, 2017

@zdavis zdavis added this to the v0.2 milestone May 8, 2017

SMaxOwok added a commit that referenced this issue May 16, 2017

SMaxOwok added a commit that referenced this issue May 16, 2017

SMaxOwok added a commit that referenced this issue May 17, 2017

zdavis added a commit that referenced this issue May 17, 2017

@zdavis

This comment has been minimized.

Show comment
Hide comment
@zdavis

zdavis May 17, 2017

Member

Fixed.

Member

zdavis commented May 17, 2017

Fixed.

@zdavis zdavis closed this May 17, 2017

@zdavis zdavis removed the in progress label Jun 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment