New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component FetchData methods should not be triggered by URL hash changes #304

Closed
SMaxOwok opened this Issue Apr 28, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@SMaxOwok
Member

SMaxOwok commented Apr 28, 2017

https://github.com/ManifoldScholar/manifold/blob/master/client/src/components/global/HigherOrder/ResolveDataDependencies.js#L28

This line causes components to call their fetchData methods when a hash is added to the URL. In some cases, this causes conflicting requests during an update.

Slack Discussion:
https://manifold-scholarship.slack.com/archives/C0BCDM82H/p1493399926648943

@zdavis

This comment has been minimized.

Show comment
Hide comment
@zdavis

zdavis May 4, 2017

Member

FetchData is being completely rewritten as part of the react-router v4 upgrade.

Member

zdavis commented May 4, 2017

FetchData is being completely rewritten as part of the react-router v4 upgrade.

zdavis added a commit that referenced this issue May 8, 2017

[F] Upgrade react-router to v4; refactor fetchData
This commit upgrades react-router to v4 and fully implements global
link handlers, which are located close to the routes themselves.
Furthermore, it moves container data fetching into a higher order
component, which is easier to understand, and rewrites much of the
server-side-rendering approach. This is an extensive refactoring
of the routing and rendering methods, and as such touches many parts
of the client-side application.

Fixes #310: Typekit fonts should load (if configured) when SSR is absent
Fixes #309: Use custom dialog box for confirmation on leaving forms
		   without saving first.
Fixes #304: Component FetchData methods should not be triggered by URL
		   hash changes
Fixes #276: Update react-router from 2.x to 4.x
Fixes #264: Improve scroll behavior on route change

zdavis added a commit that referenced this issue May 8, 2017

[F] Upgrade react-router to v4; refactor fetchData
This commit upgrades react-router to v4 and fully implements global
link handlers, which are located close to the routes themselves.
Furthermore, it moves container data fetching into a higher order
component, which is easier to understand, and rewrites much of the
server-side-rendering approach. This is an extensive refactoring
of the routing and rendering methods, and as such touches many parts
of the client-side application.

Fixes #310: Typekit fonts should load (if configured) when SSR is absent
Fixes #309: Use custom dialog box for confirmation on leaving forms
		   without saving first.
Fixes #304: Component FetchData methods should not be triggered by URL
		   hash changes
Fixes #276: Update react-router from 2.x to 4.x
Fixes #264: Improve scroll behavior on route change

zdavis added a commit that referenced this issue May 8, 2017

[F] Upgrade react-router to v4; refactor fetchData
This commit upgrades react-router to v4 and fully implements global
link handlers, which are located close to the routes themselves.
Furthermore, it moves container data fetching into a higher order
component, which is easier to understand, and rewrites much of the
server-side-rendering approach. This is an extensive refactoring
of the routing and rendering methods, and as such touches many parts
of the client-side application.

Fixes #310: Typekit fonts should load (if configured) when SSR is absent
Fixes #309: Use custom dialog box for confirmation on leaving forms
		   without saving first.
Fixes #304: Component FetchData methods should not be triggered by URL
		   hash changes
Fixes #276: Update react-router from 2.x to 4.x
Fixes #264: Improve scroll behavior on route change

zdavis added a commit that referenced this issue May 8, 2017

[F] Upgrade react-router to v4; refactor fetchData
This commit upgrades react-router to v4 and fully implements global
link handlers, which are located close to the routes themselves.
Furthermore, it moves container data fetching into a higher order
component, which is easier to understand, and rewrites much of the
server-side-rendering approach. This is an extensive refactoring
of the routing and rendering methods, and as such touches many parts
of the client-side application. This commit also begins introducing
human-readable URLs for #275, although there is additional work to be
done on that front.

Fixes #310: 	Typekit fonts should load (if configured) when SSR is
				absent
Fixes #309: 	Use custom dialog box for confirmation on leaving forms
		   		without saving first.
Fixes #304: 	Component FetchData methods should not be triggered by
				URL hash changes
Fixes #276: 	Update react-router from 2.x to 4.x
Fixes #264: 	Improve scroll behavior on route change
Starts #275: 	Implement semantic URLs

zdavis added a commit that referenced this issue May 8, 2017

[F] Upgrade react-router to v4; refactor fetchData
This commit upgrades react-router to v4 and fully implements global
link handlers, which are located close to the routes themselves.
Furthermore, it moves container data fetching into a higher order
component, which is easier to understand, and rewrites much of the
server-side-rendering approach. This is an extensive refactoring
of the routing and rendering methods, and as such touches many parts
of the client-side application. This commit also begins introducing
human-readable URLs for #275, although there is additional work to be
done on that front.

Fixes #310: Typekit fonts should load (if configured) when SSR is
absent

Fixes #309: Use custom dialog box for confirmation on leaving forms
without saving first.

Fixes #304: Component FetchData methods should not be triggered by URL
hash changes

Fixes #276: Update react-router from 2.x to 4.x

Fixes #264: Improve scroll behavior on route change

Starts #275: Implement semantic URLs

@zdavis zdavis closed this in #329 May 8, 2017

zdavis added a commit that referenced this issue May 8, 2017

[F] Upgrade react-router to v4; refactor fetchData
This commit upgrades react-router to v4 and fully implements global
link handlers, which are located close to the routes themselves.
Furthermore, it moves container data fetching into a higher order
component, which is easier to understand, and rewrites much of the
server-side-rendering approach. This is an extensive refactoring
of the routing and rendering methods, and as such touches many parts
of the client-side application. This commit also begins introducing
human-readable URLs for #275, although there is additional work to be
done on that front.

Fixes #310: Typekit fonts should load (if configured) when SSR is
absent

Fixes #309: Use custom dialog box for confirmation on leaving forms
without saving first.

Fixes #304: Component FetchData methods should not be triggered by URL
hash changes

Fixes #276: Update react-router from 2.x to 4.x

Fixes #264: Improve scroll behavior on route change

Starts #275: Implement semantic URLs

@zdavis zdavis removed the in progress label May 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment