New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style issues on users list #313

Closed
zdavis opened this Issue May 4, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@zdavis
Member

zdavis commented May 4, 2017

Opening the drawer bumps the active BG to the left (see screenshot). Also, I think the roles in the right side of the rows are probably not intended to be flush with right edge of container. Please refer to comps.

screen shot 2017-05-04 at 10 13 59 am

@naomiyaki

This comment has been minimized.

Show comment
Hide comment
@naomiyaki

naomiyaki May 4, 2017

Member

The bump to the active background is in the comps, as is the flush position of the roles, so we'll be adding padding to the active background on the right to match so that the roles aren't flush with the active background in cases where the drawer isn't used.

screen_shot_2017-05-04_at_10 22 23_am_360

Member

naomiyaki commented May 4, 2017

The bump to the active background is in the comps, as is the flush position of the roles, so we'll be adding padding to the active background on the right to match so that the roles aren't flush with the active background in cases where the drawer isn't used.

screen_shot_2017-05-04_at_10 22 23_am_360

naomiyaki added a commit that referenced this issue May 4, 2017

@naomiyaki naomiyaki added in progress and removed needs review labels May 5, 2017

@zdavis zdavis closed this in #322 May 8, 2017

zdavis added a commit that referenced this issue May 8, 2017

@zdavis zdavis removed the in progress label Oct 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment