New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project images are converted to jpegs, don't allow transparent backgrounds #335

Closed
SMaxOwok opened this Issue May 10, 2017 · 3 comments

Comments

Projects
None yet
2 participants
@SMaxOwok
Member

SMaxOwok commented May 10, 2017

screen shot 2017-05-10 at 11 55 02 am

@SMaxOwok SMaxOwok added the bug label May 10, 2017

@zdavis

This comment has been minimized.

Show comment
Hide comment
@zdavis

zdavis May 15, 2017

Member

This is happening because the :format is hardcoded in the BASE_STYLES constant in the attachments.rb concern. We could change all the small versions to png, I think — or we could explore whether it's possible to have the format simply be jpg if the input is jpg, png if the input is png, etc.

Member

zdavis commented May 15, 2017

This is happening because the :format is hardcoded in the BASE_STYLES constant in the attachments.rb concern. We could change all the small versions to png, I think — or we could explore whether it's possible to have the format simply be jpg if the input is jpg, png if the input is png, etc.

@zdavis zdavis added this to the v0.2 milestone May 15, 2017

@SMaxOwok

This comment has been minimized.

Show comment
Hide comment
@SMaxOwok

SMaxOwok May 15, 2017

Member

I started looking into this and found that we'll also need to include -background none at the start of the conversion.

Member

SMaxOwok commented May 15, 2017

I started looking into this and found that we'll also need to include -background none at the start of the conversion.

@SMaxOwok

This comment has been minimized.

Show comment
Hide comment
Member

SMaxOwok commented May 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment