New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSR mismatch when enabling download link in Slide.Caption #354

Closed
SMaxOwok opened this Issue May 19, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@SMaxOwok
Member

SMaxOwok commented May 19, 2017

screen shot 2017-05-19 at 1 24 22 pm
Currently the download button on a collection slide only appears after a resource has been viewed on its own. The download attribute is on the ResourceSerializer while the slides are first loaded with PartialResourceSerializer. I attempted to move the attribute into PartialResourceSerializer to get the download button to appear on load and saw the following error:

screen shot 2017-05-19 at 1 14 16 pm

@SMaxOwok SMaxOwok added the bug label May 19, 2017

SMaxOwok added a commit that referenced this issue May 19, 2017

@SMaxOwok

This comment has been minimized.

Show comment
Hide comment
@SMaxOwok

SMaxOwok May 19, 2017

Member

Seems like this is because the URL being supplied is absolute. I followed the convention we are using in https://github.com/ManifoldScholar/manifold/blob/master/client/src/components/frontend/Resource/Link.js and changed the <Link /> tag to an <a /> tag.

Let me know if that was the wrong approach to fix this.

Member

SMaxOwok commented May 19, 2017

Seems like this is because the URL being supplied is absolute. I followed the convention we are using in https://github.com/ManifoldScholar/manifold/blob/master/client/src/components/frontend/Resource/Link.js and changed the <Link /> tag to an <a /> tag.

Let me know if that was the wrong approach to fix this.

SMaxOwok added a commit that referenced this issue May 19, 2017

zdavis added a commit that referenced this issue May 30, 2017

@zdavis zdavis closed this in #356 May 30, 2017

zdavis added a commit that referenced this issue May 30, 2017

@zdavis zdavis removed the in progress label Oct 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment