New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing a resource annotation doesn't remove it from margin until page reload. #373

Closed
zdavis opened this Issue Jun 2, 2017 · 0 comments

Comments

Projects
None yet
2 participants
@zdavis
Member

zdavis commented Jun 2, 2017

No description provided.

@zdavis zdavis added the bug label Jun 2, 2017

@zdavis zdavis added this to the v0.2 milestone Jun 2, 2017

SMaxOwok added a commit that referenced this issue Jun 2, 2017

@SMaxOwok SMaxOwok added the in progress label Jun 2, 2017

zdavis added a commit that referenced this issue Jun 3, 2017

zdavis added a commit that referenced this issue Jun 3, 2017

[B] Fix issue with resource marker not updating on delete
This commit takes advantage of the recent addition to the entity store
middleware and reducer that allows a dispatched API call (usually for
create requests) to add the created resource to the results of a
previous request. For example, in the case of annotations, we don't
want to have to re-fetch the collection of all annotations when a new
annotation is created. With the "adds" request option, the resulting
annotation from the create request is added to the results of the
rAnnotation request.

This commit also removes older, hacky code in the entity store reducer
that was there specifically to handle this annotations use case.

[Fixes #373]

@zdavis zdavis closed this in #382 Jun 3, 2017

zdavis added a commit that referenced this issue Jun 3, 2017

[B] Fix issue with resource marker not updating on delete
This commit takes advantage of the recent addition to the entity store
middleware and reducer that allows a dispatched API call (usually for
create requests) to add the created resource to the results of a
previous request. For example, in the case of annotations, we don't
want to have to re-fetch the collection of all annotations when a new
annotation is created. With the "adds" request option, the resulting
annotation from the create request is added to the results of the
rAnnotation request.

This commit also removes older, hacky code in the entity store reducer
that was there specifically to handle this annotations use case.

[Fixes #373]

@zdavis zdavis removed the in progress label Oct 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment