Renaming stuff in README #149
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aathish04
requested changes
Jun 8, 2020
Aathish04
reviewed
Jun 13, 2020
Member
Aathish04
left a comment
Aathish04
left a comment
There was a problem hiding this comment.
I'm approving this for now, but are we even planning on renaming it to manim-ce ?
Aathish04
previously approved these changes
Jun 13, 2020
Contributor
Author
|
I believe so. Pinging @leotrs and @eulertour for input. |
Member
|
This seems premature; I don't think we reached a consensus on this. |
Member
|
Alright, removing my review for this until we reach a consensus as to what we're going to name this Manim version. |
Aathish04
dismissed
their stale review
It is not decided if the library is being renamed to this.
Contributor
|
Closing this for now. Can reopen when #163 is closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We could rename the pypi package to
manim-ce; this just fixes some stuff in the readme if we were to rename it.