New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added docstrings for :class:~.ValueTracker
#1246
Merged
RickyC0626
merged 10 commits into
ManimCommunity:master
from
kolibril13:docsting_valtracker
Apr 9, 2021
Merged
Added docstrings for :class:~.ValueTracker
#1246
RickyC0626
merged 10 commits into
ManimCommunity:master
from
kolibril13:docsting_valtracker
Apr 9, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsonvillanueva
changed the title
DocStings for ValueTracker
Added docstrings for :class:Apr 7, 2021
~.ValueTracker
RickyC0626
approved these changes
Apr 9, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍🏻
Could make it transition smoother.
for more information, see https://pre-commit.ci
naveen521kk
reviewed
Apr 9, 2021
self.set_value(self.get_value() + d_value) | ||
|
||
def __iadd__(self, d_value): | ||
"""adds `+=` syntax to increment the value of the ValueTracker""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's rst, use double ` for code and not single.
12 tasks
kolibril13
added a commit
that referenced
this pull request
Apr 9, 2021
Appends to (#1246) Co-authored-by: kolibril13 <44469195+kolibril13@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog / Overview
Added docs for ValueTracker and added the function isub, because there was already iadd
Motivation
Explanation for Changes
Testing Status
Further Comments
Checklist
Reviewer Checklist