New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Fix macOS pipeline failure #1255
CI: Fix macOS pipeline failure #1255
Conversation
This reverts commit 63f59be.
42c4948
to
89c959d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you for investigating and fixing the pipeline!
This is super helpful. Thanks for the hard work and speedy fix. I'm not familiar with brew; is the update / upgrade / cleanup necessary given we're running this in a CI env, or was it more a temporary fix? |
It was more of a temporary fix to solve the basictex issue, but it led to finding out about the legacy package. I think we can keep it as redundancy in case a similar issue occurs in the future. |
How much time does it add to the build? If we compare it to #1200 's build, it looks like it adds 4 minutes across the board. That is a lot of time for a "might be helpful" change. |
I do plan on working on caching as described in #824, for dependency-heavy packages such as ffmpeg to make the installation process faster. |
That will be helpful. For the time being, though - and assuming it still builds - can you take out that update line? Otherwise it LGTM. |
Could improve build speed
Looks like that line was necessary |
Sped up the time by a few minutes by only upgrading the brew packages we need. |
Amazing, thank you! |
Changelog / Overview
Update
ci.yml
to update and upgrade brew if necessary before installing dependencies, and remove the unsupporteddvisvgm.86_64-darwin
package.Motivation
CI macOS pipeline failure due to installation of a basictex package that no longer exists.
Exploring this avenue has also revealed that
dvisvgm.86_64-darwin
is no longer supported, as part of TeX Live 2021 release to support both ARM and Intel architectures. Instead,dvisvgm.universal-darwin
will be used for MacTex, supporting macOS 10.14+. The legacydvisvgm.x86_64-darwinlegacy
binary folder will support macOS 10.6+, but it is only available with Unix install-tl.Explanation for Changes
Testing Status
Further Comments
Checklist
Reviewer Checklist