New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New tip shape :class:.StealthTip
, allow specifying tip shape of :class:.NumberLine
#3201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
behackl
added
the
new feature
Enhancement specifically adding a new feature (feature request should be used for issues instead)
label
Apr 1, 2023
for more information, see https://pre-commit.ci
@MrDiver what is the proper way to typehint with Type? from typing import Type
tip_shape: Type[ArrowTip] | None = None or something along these lines? |
behackl
changed the title
New tip shape :class:
New tip shape :class:Apr 1, 2023
.StealthTip
.StealthTip
, allow specifying tip shape of :class:.NumberLine
This is fine like it is, theres not really a different way to type |
MrDiver
requested changes
Apr 3, 2023
MrDiver
approved these changes
Apr 3, 2023
MrDiver
previously requested changes
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
new feature
Enhancement specifically adding a new feature (feature request should be used for issues instead)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new and somewhat more fancy arrow tip shape,
StealthTip
, inspired from the corresponding TikZ arrow tip.This PR also allows properly propagating the tip shape to
Axes
andNumberline
.Reviewer Checklist