Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New tip shape :class:.StealthTip, allow specifying tip shape of :class:.NumberLine #3201

Merged
merged 11 commits into from Apr 5, 2023

Conversation

behackl
Copy link
Member

@behackl behackl commented Apr 1, 2023

This adds a new and somewhat more fancy arrow tip shape, StealthTip, inspired from the corresponding TikZ arrow tip.

This PR also allows properly propagating the tip shape to Axes and Numberline.

image

Reviewer Checklist

  • The PR title is descriptive enough for the changelog, and the PR is labeled correctly
  • If applicable: newly added non-private functions and classes have a docstring including a short summary and a PARAMETERS section
  • If applicable: newly added functions and classes are tested

@behackl behackl added the new feature Enhancement specifically adding a new feature (feature request should be used for issues instead) label Apr 1, 2023
@behackl
Copy link
Member Author

behackl commented Apr 1, 2023

@MrDiver what is the proper way to typehint with Type?

from typing import Type

tip_shape: Type[ArrowTip] | None = None

or something along these lines?

@behackl behackl changed the title New tip shape :class:.StealthTip New tip shape :class:.StealthTip, allow specifying tip shape of :class:.NumberLine Apr 1, 2023
@MrDiver
Copy link
Collaborator

MrDiver commented Apr 3, 2023

@MrDiver what is the proper way to typehint with Type?

from typing import Type

tip_shape: Type[ArrowTip] | None = None

or something along these lines?

This is fine like it is, theres not really a different way to type Type

MrDiver
MrDiver previously requested changes Apr 3, 2023
manim/mobject/graphing/number_line.py Show resolved Hide resolved
@behackl behackl dismissed MrDiver’s stale review April 5, 2023 18:04

Already taken care of

@behackl behackl merged commit a6651be into ManimCommunity:main Apr 5, 2023
19 checks passed
@behackl behackl deleted the stealth-tips branch April 5, 2023 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature Enhancement specifically adding a new feature (feature request should be used for issues instead)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants