Skip to content
A bunch of lints to catch common mistakes and improve your Rust code
Branch: master
Clone or download
Pull request Compare This branch is 371 commits behind rust-lang:master.
bors Auto merge of rust-lang#4080 - rust-lang:rustup, r=oli-obk
Rustup to rustc 1.36.0-nightly (acc7e652f 2019-05-10)

Fixes breakages from rust-lang/rust#59288

Not finished yet, help appreciated.

Todo:

 - [x] Needs to build
 - [x] Util should handle DropTemps, rust-lang#4080 (comment)
 - [x] Author lint should spit out higher::if_block checks
 - [x] Unsure what to do in consts.rs
 - [x] Needs to pass tests
Latest commit 3710ec5 May 11, 2019
Permalink
Type Name Latest commit message Commit time
Failed to load latest commit information.
.cargo Enable -Zunstable-options in .cargo/config Apr 15, 2019
.github Update PULL_REQUEST_TEMPLATE Apr 16, 2019
ci Exclude ice-3891.rs from rustfmt run Apr 9, 2019
clippy_dev Remove rust-toolchain file from clippy_dev Apr 16, 2019
clippy_dummy
clippy_lints Start handling desugarings in author lint May 11, 2019
clippy_workspace_tests Transition leftover test libs to Rust 2018 Feb 3, 2019
doc Document `declare_lint_pass!` Apr 17, 2019
etc/relicense Fix some nursery links Dec 2, 2018
mini-macro Transition leftover test libs to Rust 2018 Feb 3, 2019
rustc_tools_util rustc_tools_util: try to handle case of not having CFG_RELEASE_CHANNE… Apr 28, 2019
src clippy-driver: use rustc_tools_util to get version info. May 1, 2019
tests Start handling desugarings in author lint May 11, 2019
util move lint documentation into macro invocations Mar 5, 2019
.editorconfig Add EditorConfig Jul 15, 2016
.gitattributes gitattributes: Treat .fixed files as rust files Jan 25, 2019
.gitignore consistently gitignore all Cargo.lock files Sep 27, 2018
.remarkrc.json use .remarkrc.json for travis May 6, 2016
.travis.yml travis: sort integration test jobs so that the jobs taking the most t… Apr 28, 2019
CHANGELOG.md
CODE_OF_CONDUCT.md Add missing code of conduct file Nov 1, 2018
CONTRIBUTING.md Cleanup 'Writing code' in CONTRIBUTING.md Mar 3, 2019
COPYRIGHT Remove all copyright license headers Jan 8, 2019
Cargo.toml use `derive` feature over `serde_derive` crate May 9, 2019
LICENSE-APACHE Relicense clippy Oct 6, 2018
LICENSE-MIT
PUBLISH.md Cleanup old min_version stuff Sep 3, 2018
README.md Add lints for find_map Apr 30, 2019
appveyor.yml Only run AppVeyor on r+, try and the master branch Apr 24, 2019
build.rs Remove all copyright license headers Jan 8, 2019
pre_publish.sh Remove all copyright license headers Jan 8, 2019
publish.files CHANGELOG is ordered after Cargo Jun 16, 2017
rust-toolchain Add rust-toolchain file Jul 11, 2018
rustfmt.toml Error on line overflow Nov 27, 2018
setup-toolchain.sh Add setup-toolchain.sh script to configure the master version of rustc, Feb 3, 2019

README.md

Clippy

Build Status Windows Build status Current Version License: MIT/Apache-2.0

A collection of lints to catch common mistakes and improve your Rust code.

There are 301 lints included in this crate!

We have a bunch of lint categories to allow you to choose how much Clippy is supposed to annoy help you:

  • clippy::all (everything that is on by default: all the categories below except for nursery, pedantic, and cargo)
  • clippy::correctness (code that is just outright wrong or very very useless, causes hard errors by default)
  • clippy::style (code that should be written in a more idiomatic way)
  • clippy::complexity (code that does something simple but in a complex way)
  • clippy::perf (code that can be written in a faster way)
  • clippy::pedantic (lints which are rather strict, off by default)
  • clippy::nursery (new lints that aren't quite ready yet, off by default)
  • clippy::cargo (checks against the cargo manifest, off by default)

More to come, please file an issue if you have ideas!

Only the following of those categories are enabled by default:

  • clippy::style
  • clippy::correctness
  • clippy::complexity
  • clippy::perf

Other categories need to be enabled in order for their lints to be executed.

The lint list also contains "restriction lints", which are for things which are usually not considered "bad", but may be useful to turn on in specific cases. These should be used very selectively, if at all.

Table of contents:

Usage

Since this is a tool for helping the developer of a library or application write better code, it is recommended not to include Clippy as a hard dependency. Options include using it as an optional dependency, as a cargo subcommand, or as an included feature during build. These options are detailed below.

As a cargo subcommand (cargo clippy)

One way to use Clippy is by installing Clippy through rustup as a cargo subcommand.

Step 1: Install rustup

You can install rustup on supported platforms. This will help us install Clippy and its dependencies.

If you already have rustup installed, update to ensure you have the latest rustup and compiler:

rustup update

Step 2: Install Clippy

Once you have rustup and the latest stable release (at least Rust 1.29) installed, run the following command:

rustup component add clippy

If it says that it can't find the clippy component, please run rustup self update.

Step 3: Run Clippy

Now you can run Clippy by invoking the following command:

cargo clippy

Running Clippy from the command line without installing it

To have cargo compile your crate with Clippy without Clippy installation in your code, you can use:

cargo run --bin cargo-clippy --manifest-path=path_to_clippys_Cargo.toml

Note: Be sure that Clippy was compiled with the same version of rustc that cargo invokes here!

Travis CI

You can add Clippy to Travis CI in the same way you use it locally:

language: rust
rust:
  - stable
  - beta
before_script:
  - rustup component add clippy
script:
  - cargo clippy
  # if you want the build job to fail when encountering warnings, use
  - cargo clippy -- -D warnings
  # in order to also check tests and non-default crate features, use
  - cargo clippy --all-targets --all-features -- -D warnings
  - cargo test
  # etc.

If you are on nightly, It might happen that Clippy is not available for a certain nightly release. In this case you can try to conditionally install Clippy from the git repo.

language: rust
rust:
  - nightly
before_script:
   - rustup component add clippy --toolchain=nightly || cargo install --git https://github.com/rust-lang/rust-clippy/ --force clippy
   # etc

Note that adding -D warnings will cause your build to fail if any warnings are found in your code. That includes warnings found by rustc (e.g. dead_code, etc.). If you want to avoid this and only cause an error for clippy warnings, use #![deny(clippy::all)] in your code or -D clippy::all on the command line. (You can swap clippy::all with the specific lint category you are targeting.)

Configuration

Some lints can be configured in a TOML file named clippy.toml or .clippy.toml. It contains a basic variable = value mapping eg.

blacklisted-names = ["toto", "tata", "titi"]
cognitive-complexity-threshold = 30

See the list of lints for more information about which lints can be configured and the meaning of the variables.

To deactivate the “for further information visit lint-link” message you can define the CLIPPY_DISABLE_DOCS_LINKS environment variable.

Allowing/denying lints

You can add options to your code to allow/warn/deny Clippy lints:

  • the whole set of Warn lints using the clippy lint group (#![deny(clippy::all)])

  • all lints using both the clippy and clippy::pedantic lint groups (#![deny(clippy::all)], #![deny(clippy::pedantic)]). Note that clippy::pedantic contains some very aggressive lints prone to false positives.

  • only some lints (#![deny(clippy::single_match, clippy::box_vec)], etc)

  • allow/warn/deny can be limited to a single function or module using #[allow(...)], etc

Note: deny produces errors instead of warnings.

If you do not want to include your lint levels in your code, you can globally enable/disable lints by passing extra flags to Clippy during the run: cargo clippy -- -A clippy::lint_name will run Clippy with lint_name disabled and cargo clippy -- -W clippy::lint_name will run it with that enabled. This also works with lint groups. For example you can run Clippy with warnings for all lints enabled: cargo clippy -- -W clippy::pedantic

Contributing

If you want to contribute to Clippy, you can find more information in CONTRIBUTING.md.

License

Copyright 2014-2019 The Rust Project Developers

Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or http://www.apache.org/licenses/LICENSE-2.0> or the MIT license <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your option. All files in the project carrying such notice may not be copied, modified, or distributed except according to those terms.

You can’t perform that action at this time.