Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unify the dimension of the flags #44

Closed
jabbalaci opened this issue Jun 21, 2016 · 9 comments
Closed

unify the dimension of the flags #44

jabbalaci opened this issue Jun 21, 2016 · 9 comments

Comments

@jabbalaci
Copy link
Contributor

Currently the flag screenshots are all different. There should be a guideline about 1) the size of these images, and 2) the size of the margins around the flags.

@manrajgrover
Copy link
Owner

@jabbalaci Yes, definitely. Seriously, there is a need to first fix this. Thank you for opening this issue. Would you like to suggest some guidelines?

@module17
Copy link

@jabbalaci Agreed. Also, perhaps the correct flag proportions should be enforced. I believe most are defined and shown on Wikipedia.

@manrajgrover
Copy link
Owner

@module17 Apart from proportions, we should give a set canvas beyond which person cannot go.

Or should we just give exact dimensions? Are there any online tools to check this?

@module17
Copy link

@manrajgrover Absolutely. Perhaps we can set a maximum width. The proportions will vary, but we can limit the "display width" of the div representation as well as any included assets. Hmm, but then again some flags with such a small maximum width wouldn't be able to show the finer details adequately. 600 pixels?

@module17
Copy link

Also, @jabbalaci I agree that whitespace guidelines should exist as well. I don't see a reason for any whitespace or margins personally.

@jabbalaci
Copy link
Contributor Author

I think some pixels can be allowed for the margins, but not much more. It could be difficult to crop the flag perfectly, but some pixel rows and columns around the flag are acceptable IMO.

@module17
Copy link

@jabbalaci If we use SVG and generate PNG from fixed SVG export size we can be consistent. Maybe?

@manrajgrover
Copy link
Owner

A good and fast solution to this looks to be mentioned here. I'll try it out soon or would love a PR for fixing this. 😄

@manrajgrover
Copy link
Owner

This has now been fixed. 😄 Closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants