Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Removed variables that where causing compiler error. #228

Closed
wants to merge 1 commit into from

2 participants

Nicolas Goles Robert Böhnke
Nicolas Goles
  • The error happened when the Debug.xcconfig conflicting flag was removed to compile Mantle under Xcode 5.1.
Nicolas Goles Goles Removed variables that where causing compiler error.
* The error happened when the Debug.xcconfig conflicting flag was
removed to compile Mantle under Xcode 5.1.
8264d5a
Robert Böhnke
Collaborator

Duplicate of #227?

Robert Böhnke
Collaborator

Sorry for being so terse earlier, I was on my phone.

Anyhow, MTLJSONAdapterErrorExceptionThrown is actually being used if you compile without the DEBUG flag so it can't be removed. MTLManagedObjectAdapterErrorExceptionThrown isn't at all, however, I've updated #227 to reflect that :+1:

Robert Böhnke robb closed this
Nicolas Goles

That's fair enough, just wanted to send out a P.R instead of just ask for fixes etc :+1:

Cheers @robb

Nicolas Goles Goles deleted the branch
Robert Böhnke
Collaborator

just wanted to send out a P.R instead of just ask for fixes

Totally appreciated :sparkling_heart:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Feb 2, 2014
  1. Nicolas Goles

    Removed variables that where causing compiler error.

    Goles authored
    * The error happened when the Debug.xcconfig conflicting flag was
    removed to compile Mantle under Xcode 5.1.
This page is out of date. Refresh to see the latest.
Showing with 0 additions and 6 deletions.
  1. +0 −3  Mantle/MTLJSONAdapter.m
  2. +0 −3  Mantle/MTLManagedObjectAdapter.m
3  Mantle/MTLJSONAdapter.m
View
@@ -14,9 +14,6 @@
const NSInteger MTLJSONAdapterErrorNoClassFound = 2;
const NSInteger MTLJSONAdapterErrorInvalidJSONDictionary = 3;
-// An exception was thrown and caught.
-static const NSInteger MTLJSONAdapterErrorExceptionThrown = 1;
-
// Associated with the NSException that was caught.
static NSString * const MTLJSONAdapterThrownExceptionErrorKey = @"MTLJSONAdapterThrownException";
3  Mantle/MTLManagedObjectAdapter.m
View
@@ -34,9 +34,6 @@ static id performInContext(NSManagedObjectContext *context, id (^block)(void)) {
return result;
}
-// An exception was thrown and caught.
-static const NSInteger MTLManagedObjectAdapterErrorExceptionThrown = 1;
-
@interface MTLManagedObjectAdapter ()
// The MTLModel subclass being serialized or deserialized.
Something went wrong with that request. Please try again.