Fix mapping nil transformer output back to NSNull #792
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: if a transformer encodes a value to
nil
, it's converted to a missing value, not to anull
value.Example. My model has an integer value. In case of equality to
INVALID_VALUE
constant, it should be encoded asnull
. So I implement the transformer as follows:I convert a structure with an invalid value in a following manner: model → JSON → model. And the value is transformed as
INVALID_VALUE
→ absent value → 0 (not assigned).The reason is a mistake in MTLJSONAdapter. As stated in comments, it maps NSNull → nil to use the transformer, and then back after the transformer. But the reverse mapping isn't performed in this specific case.