Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HoloEverywhere #4

Closed
fabriciomassula opened this issue Jun 6, 2013 · 4 comments
Closed

HoloEverywhere #4

fabriciomassula opened this issue Jun 6, 2013 · 4 comments

Comments

@fabriciomassula
Copy link

Hello,

I would like to use it with HoloEverywhere library (https://github.com/Prototik/HoloEverywhere). When trying to use it, the library send me an error message saying that my activity should be an instance of SherlockActivity (and it is the HoloEverywhere activity...).

Thnks and congrats for yout great work!!

@ManuelPeinado
Copy link
Owner

Thanks!

Your activity must indeed derive from SherlockActivity, otherwise how will you implement a backwards-compatible action bar?

@fabriciomassula
Copy link
Author

Hello,

As you can see on HoloEverywhere basic migration guide (https://github.com/Prototik/HoloEverywhere/wiki/Basic-migration-on-HoloEverywhere), while using the library, we always extend our activities from ¨org.holoeverywhere.app.***Activity¨ and the library takes care of compatibility issues with ActionBarSherlock.

Thnks

@ManuelPeinado
Copy link
Owner

I see. Let me think of something, I'll get back to you.

@ManuelPeinado
Copy link
Owner

I've just pushed a fix to your problem to the "dev" branch. With this fix the library will work with any activity that implements a method called "getSupportActionBar", regardless of whether it derives from any of the ABS activities.

Please test it and tell me if it works for you, before I integrate it with the master branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants